Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1485333007: Mark deprecated debugger APIs as such (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark deprecated debugger APIs as such We should consider deprecating the message based API as well in the future. BUG=none R=yangguo@chromium.org LOG=y Committed: https://crrev.com/0f2bffa11e17603682c99b353a2910e818a78716 Cr-Commit-Position: refs/heads/master@{#32621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M include/v8-debug.h View 6 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-12-03 12:23:22 UTC) #1
Yang
On 2015/12/03 12:23:22, jochen wrote: lgtm
5 years ago (2015-12-03 14:51:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485333007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485333007/1
5 years ago (2015-12-04 15:00:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 15:25:16 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-04 15:25:49 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0f2bffa11e17603682c99b353a2910e818a78716
Cr-Commit-Position: refs/heads/master@{#32621}

Powered by Google App Engine
This is Rietveld 408576698