components/omnibox/browser/omnibox_edit_model.cc - Issue 1485333006: Abstract callout to OmniboxEditController on updating input in progress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/omnibox_edit_model.cc

Issue 1485333006: Abstract callout to OmniboxEditController on updating input in progress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + response to review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/omnibox/browser/omnibox_edit_model.cc

diff --git a/components/omnibox/browser/omnibox_edit_model.cc b/components/omnibox/browser/omnibox_edit_model.cc

index e6efb0ef9ae6da3123bca1562c6be6fa2192e38a..e194a039dbbb0fd543ecd3330297832b5b5f05f7 100644

--- a/components/omnibox/browser/omnibox_edit_model.cc

+++ b/components/omnibox/browser/omnibox_edit_model.cc

@@ -451,8 +451,7 @@ void OmniboxEditModel::SetInputInProgress(bool in_progress) {

autocomplete_controller()->ResetSession();

}

- controller_->GetToolbarModel()->set_input_in_progress(in_progress);

- controller_->UpdateWithoutTabRestore();

+ controller_->OnInputInProgress(in_progress);

if (user_input_in_progress_ || !in_revert_)

client_->OnInputStateChanged();

« no previous file with comments | « components/omnibox/browser/omnibox_edit_controller.h ('k') | no next file » | no next file with comments »