components/omnibox/browser/omnibox_edit_controller.h - Issue 1485333006: Abstract callout to OmniboxEditController on updating input in progress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/omnibox_edit_controller.h

Issue 1485333006: Abstract callout to OmniboxEditController on updating input in progress (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase + response to review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/omnibox/chrome_omnibox_edit_controller.cc ('k') | components/omnibox/browser/omnibox_edit_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/omnibox_edit_controller.h

diff --git a/components/omnibox/browser/omnibox_edit_controller.h b/components/omnibox/browser/omnibox_edit_controller.h

index 26b453fd7a3edabff4166785f618bf3c8dbf146b..622c48521e05d1b102dbca32e3d3ac83434d82f0 100644

--- a/components/omnibox/browser/omnibox_edit_controller.h

+++ b/components/omnibox/browser/omnibox_edit_controller.h

@@ -22,9 +22,7 @@ class OmniboxEditController {

WindowOpenDisposition disposition,

ui::PageTransition transition);

- // Called when the the controller should update itself without restoring any

- // tab state.

- virtual void UpdateWithoutTabRestore() = 0;

+ virtual void OnInputInProgress(bool in_progress) = 0;

// Called when anything has changed that might affect the layout or contents

// of the views around the edit, including the text of the edit and the

« no previous file with comments | « chrome/browser/ui/omnibox/chrome_omnibox_edit_controller.cc ('k') | components/omnibox/browser/omnibox_edit_model.cc » ('j') | no next file with comments »