Abstract callout to OmniboxEditController on updating input in progress

Abstract callout to OmniboxEditController on updating input in progress

Currently, OmniboxEditModel invokes specific functionality on
OmniboxEditController when input is in progress. However, the iOS port has
different requirements in this case. This CL changes the flow so that
OmniboxEditModel calls the (new) OmniboxEditController::SetInputInProgress()
method. ChromeOmniboxEditController's implementation of this new method is the
code that was previously in OmniboxEditModel.

Committed: https://crrev.com/91db62076467d9f6d922bad595a8ba3c350bb6b4
Cr-Commit-Position: refs/heads/master@{#364043}

[blundell, 2015-12-03 12:40:37]

blundell@chromium.org changed reviewers:
+ pkasting@chromium.org

[blundell, 2015-12-03 12:40:38]

Hi Peter,

I apologize for this CL being somewhat opaque due to the iOS subclass of
OmniboxEditController not yet being upstreamable :P.

[blundell, 2015-12-07 09:47:05]

Ping.

[Peter Kasting, 2015-12-08 20:42:28]

LGTM

https://codereview.chromium.org/1485333006/diff/1/components/omnibox/browser/...
File components/omnibox/browser/omnibox_edit_controller.h (right):

https://codereview.chromium.org/1485333006/diff/1/components/omnibox/browser/...
components/omnibox/browser/omnibox_edit_controller.h:25: virtual void
SetInputInProgress(bool in_progress) = 0;
You might want to name this OnInputInProgress() since it's basically a reaction
to input being in progress rather than a function that causes input to be in
progress?  (I know it then calls a set_input_in_progress(), but that's so named
because it's a direct accessor.)

[blundell, 2015-12-09 10:42:32]

https://codereview.chromium.org/1485333006/diff/1/components/omnibox/browser/...
File components/omnibox/browser/omnibox_edit_controller.h (right):

https://codereview.chromium.org/1485333006/diff/1/components/omnibox/browser/...
components/omnibox/browser/omnibox_edit_controller.h:25: virtual void
SetInputInProgress(bool in_progress) = 0;
On 2015/12/08 20:42:28, Peter Kasting wrote:
> You might want to name this OnInputInProgress() since it's basically a
reaction
> to input being in progress rather than a function that causes input to be in
> progress?  (I know it then calls a set_input_in_progress(), but that's so
named
> because it's a direct accessor.)

Done.

[blundell, 2015-12-09 10:42:36]

The CQ bit was checked by blundell@chromium.org

[blundell, 2015-12-09 10:42:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1485333006/#ps20001
(title: "Rebase + response to review")

[commit-bot: I haz the power, 2015-12-09 10:43:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485333006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485333006/20001

[commit-bot: I haz the power, 2015-12-09 12:00:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-09 12:00:50]

Description was changed from

==========
Abstract callout to OmniboxEditController on updating input in progress

Currently, OmniboxEditModel invokes specific functionality on
OmniboxEditController when input is in progress. However, the iOS port has
different requirements in this case. This CL changes the flow so that
OmniboxEditModel calls the (new) OmniboxEditController::SetInputInProgress()
method. ChromeOmniboxEditController's implementation of this new method is the
code that was previously in OmniboxEditModel.
==========

to

==========
Abstract callout to OmniboxEditController on updating input in progress

Currently, OmniboxEditModel invokes specific functionality on
OmniboxEditController when input is in progress. However, the iOS port has
different requirements in this case. This CL changes the flow so that
OmniboxEditModel calls the (new) OmniboxEditController::SetInputInProgress()
method. ChromeOmniboxEditController's implementation of this new method is the
code that was previously in OmniboxEditModel.

Committed: https://crrev.com/91db62076467d9f6d922bad595a8ba3c350bb6b4
Cr-Commit-Position: refs/heads/master@{#364043}
==========

[commit-bot: I haz the power, 2015-12-09 12:00:51]

Patchset 2 (id:??) landed as
https://crrev.com/91db62076467d9f6d922bad595a8ba3c350bb6b4
Cr-Commit-Position: refs/heads/master@{#364043}