Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1485303002: PPC: Provide call counts for constructor calls, surface them as a vector IC. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Provide call counts for constructor calls, surface them as a vector IC. Port 66d5a9df62da458a51e8c7ed1811dc9660f4f418 Original commit message: CallIC and CallConstructStub look so alike, at least in the feedback they gather even if the implementation differs...and CallIC has such a nice way of surfacing the feedback (CallICNexus), that there is a request to make CallConstructStub look analogous. Enter ConstructICStub. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/8ea834385e4542ebccb2fb0239cc10a2b0d01442 Cr-Commit-Position: refs/heads/master@{#32481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 5 chunks +21 lines, -4 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
5 years ago (2015-12-01 22:11:01 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485303002/1
5 years ago (2015-12-01 22:20:05 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/124)
5 years ago (2015-12-01 22:28:42 UTC) #5
michael_dawson
On 2015/12/01 22:28:42, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
5 years ago (2015-12-01 22:52:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485303002/1
5 years ago (2015-12-01 23:00:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 23:09:42 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-01 23:09:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ea834385e4542ebccb2fb0239cc10a2b0d01442
Cr-Commit-Position: refs/heads/master@{#32481}

Powered by Google App Engine
This is Rietveld 408576698