third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-add-expected.txt - Issue 1485283002: Sync Cache API tests w/ web-platform-tests

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-add-expected.txt

Issue 1485283002: Sync Cache API tests w/ web-platform-tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js ('k') | third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-match-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/cache-put-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 This is a testharness.js-based test.

	2 PASS Cache.add and Cache.addAll

	3 PASS Cache.add called with no arguments

	4 PASS Cache.add called with relative URL specified as a string

	5 PASS Cache.add called with non-HTTP/HTTPS URL

	6 PASS Cache.add called with Request object

	7 PASS Cache.add called with POST request

	8 PASS Cache.add called twice with the same Request object

	9 PASS Cache.add called with Request object with a used body

	10 PASS Cache.add with request that results in a status of 404

	11 PASS Cache.add with request that results in a status of 500

	12 PASS Cache.addAll with no arguments

	13 PASS Cache.addAll with a mix of valid and undefined arguments

	14 PASS Cache.addAll with an empty array

	15 PASS Cache.addAll with string URL arguments

	16 PASS Cache.addAll with Request arguments

	17 PASS Cache.addAll with a mix of succeeding and failing requests

	18 FAIL Cache.addAll called with the same Request object specified twice promise_te st: Unhandled rejection with value: "assert_promise_rejects: Cache.addAll should throw InvalidStateError if the same request is added twice. Promise did not rej ect."
	jsbell 2015/12/01 20:50:49 Test assumes that the body will be consumed. This Test assumes that the body will be consumed. This looks wrong upstream if I'm reading the fetch spec correctly, since request's empty body won't be disturbed. yhirano 2015/12/02 06:58:52 A request with a null body should not be disturbed Show quoted text On 2015/12/01 20:50:49, jsbell wrote: > Test assumes that the body will be consumed. This looks wrong upstream if I'm > reading the fetch spec correctly, since request's empty body won't be disturbed. A request with a null body should not be disturbed, but a request with an empty body should be disturbed. jkarlin 2015/12/02 16:42:45 Agreed. So should we incorporate the change and fi Show quoted text On 2015/12/01 20:50:49, jsbell wrote: > Test assumes that the body will be consumed. This looks wrong upstream if I'm > reading the fetch spec correctly, since request's empty body won't be disturbed. Agreed. So should we incorporate the change and file a bug upstream? jsbell 2015/12/02 17:17:46 +1, but I want to hear if yhirano agrees. Show quoted text On 2015/12/02 16:42:45, jkarlin wrote: > On 2015/12/01 20:50:49, jsbell wrote: > > Test assumes that the body will be consumed. This looks wrong upstream if I'm > > reading the fetch spec correctly, since request's empty body won't be > disturbed. > > Agreed. So should we incorporate the change and file a bug upstream? +1, but I want to hear if yhirano agrees. yhirano 2015/12/03 01:58:18 Oh, sorry, I misunderstood. You're right, request' Show quoted text On 2015/12/02 17:17:46, jsbell wrote: > On 2015/12/02 16:42:45, jkarlin wrote: > > On 2015/12/01 20:50:49, jsbell wrote: > > > Test assumes that the body will be consumed. This looks wrong upstream if > I'm > > > reading the fetch spec correctly, since request's empty body won't be > > disturbed. > > > > Agreed. So should we incorporate the change and file a bug upstream? > > +1, but I want to hear if yhirano agrees. Oh, sorry, I misunderstood. You're right, request's body is always null (not empty) because its method is 'GET', and hence the reuqest cannot be locked or disturbed.
	19 Harness: the test ran to completion.

	20

OLD	NEW