Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: ui/ozone/platform/drm/host/drm_window_host.cc

Issue 1485233002: Force touch events to be dispatched on FNL (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/ozone/platform/drm/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/ozone/platform/drm/host/drm_window_host.cc
diff --git a/ui/ozone/platform/drm/host/drm_window_host.cc b/ui/ozone/platform/drm/host/drm_window_host.cc
index 51c19ce06386987c17088c16aff9ed2c64a46a98..5cba0cb10644d41196b8a71ce0adb4945a440770 100644
--- a/ui/ozone/platform/drm/host/drm_window_host.cc
+++ b/ui/ozone/platform/drm/host/drm_window_host.cc
@@ -128,6 +128,18 @@ bool DrmWindowHost::CanDispatchEvent(const PlatformEvent& ne) {
return grabber == widget_;
if (event->IsTouchEvent()) {
+#ifdef FORCE_DISPATCH_TOUCH_EVENTS
+ // TODO(lanechr): This bypasses checks that ensure that touch events
+ // are dispatched to the right display. The "right display" is defined as
+ // "the display associated with the touch device." Displays are associated
+ // with touch devices through DeviceDataManager::UpdateTouchInfoForDisplay,
jamesr 2015/12/01 23:25:21 wouldn't we call this from https://github.com/domo
+ // which (as of today) is never called.
+ //
+ // I'm not sure yet how to best determine touchscreen/display association,
+ // but FNL currently only supports devices with one touch screen. So for
+ // now, always dispatch touch events on FNL devices.
+ return true;
+#endif
// Dispatch the event if it is from the touchscreen associated with the
// DrmWindowHost. We cannot check the event's location because if the
// touchscreen has a bezel, touches in the bezel have a location outside of
« no previous file with comments | « ui/ozone/platform/drm/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698