Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: runtime/vm/assembler_x64_test.cc

Issue 148523014: Setup valid pool pointer in assembler tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_x64_test.cc
diff --git a/runtime/vm/assembler_x64_test.cc b/runtime/vm/assembler_x64_test.cc
index 00b845006d68910561c15d7e0afcb8b10e421761..38567f0cefe28065dea29e1ffd239ffc7f994893 100644
--- a/runtime/vm/assembler_x64_test.cc
+++ b/runtime/vm/assembler_x64_test.cc
@@ -1473,10 +1473,13 @@ ASSEMBLER_TEST_GENERATE(PackedDoubleNegate, assembler) {
double a;
double b;
} constant0 = { 1.0, 2.0 };
+ __ pushq(PP); // Save caller's pool pointer and load a new one here.
+ __ LoadPoolPointer(PP);
__ movq(RAX, Immediate(reinterpret_cast<uword>(&constant0)));
__ movups(XMM10, Address(RAX, 0));
__ negatepd(XMM10);
__ movaps(XMM0, XMM10);
+ __ popq(PP); // Restore caller's pool pointer.
__ ret();
}
@@ -1493,10 +1496,13 @@ ASSEMBLER_TEST_GENERATE(PackedDoubleAbsolute, assembler) {
double a;
double b;
} constant0 = { -1.0, 2.0 };
+ __ pushq(PP); // Save caller's pool pointer and load a new one here.
+ __ LoadPoolPointer(PP);
__ movq(RAX, Immediate(reinterpret_cast<uword>(&constant0)));
__ movups(XMM10, Address(RAX, 0));
__ abspd(XMM10);
__ movaps(XMM0, XMM10);
+ __ popq(PP); // Restore caller's pool pointer.
__ ret();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698