Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148523012: DevTools: [CSS] remove getAllStylesheets method from protocol (Closed)

Created:
6 years, 10 months ago by lushnikov
Modified:
6 years, 10 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [CSS] remove getAllStylesheets method from protocol This patch removes getAllStylesheets method from protocol. Instead, clients should track styleSheetAdded/styleSheetRemoved events to maintain actual stylesheet set. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166228

Patch Set 1 #

Total comments: 6

Patch Set 2 : rebaseline and address @apavlov comments #

Patch Set 3 : fix broken reitvield chunks #

Patch Set 4 : another attempt to upload patch #

Patch Set 5 : fix tests #

Patch Set 6 : fix testcase extension #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -261 lines) Patch
M LayoutTests/inspector-protocol/css/css-setStyleText.html View 1 2 3 4 1 chunk +10 lines, -17 lines 0 comments Download
D LayoutTests/inspector-protocol/shadow-dom-rules-in-getAllStyleSheets.html View 1 2 3 4 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/inspector-protocol/shadow-dom-rules-in-getAllStyleSheets-expected.txt View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
A + LayoutTests/inspector-protocol/shadow-dom-rules-in-styleSheetAddedEvent.html View 1 2 3 4 5 1 chunk +11 lines, -17 lines 0 comments Download
A + LayoutTests/inspector-protocol/shadow-dom-rules-in-styleSheetAddedEvent-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/styles/parse-stylesheet-errors.html View 1 1 chunk +4 lines, -9 lines 0 comments Download
M LayoutTests/inspector/styles/set-property-boundaries.html View 1 1 chunk +5 lines, -10 lines 0 comments Download
M LayoutTests/inspector/styles/styles-history.html View 1 2 chunks +7 lines, -12 lines 0 comments Download
M LayoutTests/inspector/styles/styles-new-API.html View 1 2 chunks +5 lines, -8 lines 0 comments Download
M LayoutTests/inspector/styles/styles-new-API-expected.txt View 2 chunks +64 lines, -64 lines 0 comments Download
A LayoutTests/inspector/styles/styles-test.js View 1 1 chunk +36 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 4 5 1 chunk +0 lines, -9 lines 0 comments Download
M Source/devtools/front_end/AuditRules.js View 2 chunks +19 lines, -37 lines 0 comments Download
M Source/devtools/front_end/CSSStyleModel.js View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/StyleSheetOutlineDialog.js View 1 chunk +5 lines, -17 lines 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 36 (0 generated)
lushnikov
Please, take a look
6 years, 10 months ago (2014-01-29 09:35:57 UTC) #1
pfeldman
lgtm
6 years, 10 months ago (2014-01-29 14:02:29 UTC) #2
apavlov
lgtm https://codereview.chromium.org/148523012/diff/1/LayoutTests/inspector/styles/styles-new-API.html File LayoutTests/inspector/styles/styles-new-API.html (right): https://codereview.chromium.org/148523012/diff/1/LayoutTests/inspector/styles/styles-new-API.html#newcode8 LayoutTests/inspector/styles/styles-new-API.html:8: <script src="./styles-test.js"></script> "./styles-test.js" -> "styles-test.js" will make sense ...
6 years, 10 months ago (2014-01-29 14:08:56 UTC) #3
lushnikov
Thanks guys for your reviews! https://codereview.chromium.org/148523012/diff/1/LayoutTests/inspector/styles/styles-new-API.html File LayoutTests/inspector/styles/styles-new-API.html (right): https://codereview.chromium.org/148523012/diff/1/LayoutTests/inspector/styles/styles-new-API.html#newcode8 LayoutTests/inspector/styles/styles-new-API.html:8: <script src="./styles-test.js"></script> On 2014/01/29 ...
6 years, 10 months ago (2014-01-29 18:21:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/148523012/60001
6 years, 10 months ago (2014-01-30 08:14:53 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=19536
6 years, 10 months ago (2014-01-30 10:34:39 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 10:34:52 UTC) #7
lushnikov
@apavlov, fixed tests, please take another look
6 years, 10 months ago (2014-01-30 14:42:04 UTC) #8
apavlov
lgtm
6 years, 10 months ago (2014-01-30 14:46:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/148523012/80001
6 years, 10 months ago (2014-01-30 14:46:36 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=19621
6 years, 10 months ago (2014-01-30 16:21:45 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 16:22:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/148523012/80001
6 years, 10 months ago (2014-01-30 16:31:16 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=19630
6 years, 10 months ago (2014-01-30 17:55:19 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 17:55:29 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 17:56:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/148523012/80001
6 years, 10 months ago (2014-01-30 22:27:37 UTC) #17
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=19682
6 years, 10 months ago (2014-01-30 23:55:37 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 23:55:40 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-30 23:56:15 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/148523012/80001
6 years, 10 months ago (2014-01-31 08:03:16 UTC) #21
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=19758
6 years, 10 months ago (2014-01-31 09:27:00 UTC) #22
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 09:27:06 UTC) #23
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 09:27:08 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/148523012/100001
6 years, 10 months ago (2014-01-31 12:18:15 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-01-31 15:31:59 UTC) #26
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=10277
6 years, 10 months ago (2014-01-31 15:32:01 UTC) #27
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 15:32:16 UTC) #28
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 15:32:19 UTC) #29
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 15:32:24 UTC) #30
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 10 months ago (2014-01-31 15:48:40 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/148523012/100001
6 years, 10 months ago (2014-01-31 15:49:10 UTC) #32
commit-bot: I haz the power
Change committed as 166228
6 years, 10 months ago (2014-01-31 18:05:58 UTC) #33
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 18:06:05 UTC) #34
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 18:06:09 UTC) #35
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 18:06:25 UTC) #36
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698