Issue 148523011: Add dependency operand to HLoadNamedField.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148523011: Add dependency operand to HLoadNamedField. (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer

Modified:
6 years, 10 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -79 lines)			Patch
M	src/code-stubs-hydrogen.cc	View		14 chunks	+36 lines, -21 lines	0 comments	Download
M	src/hydrogen.cc	View		26 chunks	+81 lines, -54 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		2 chunks	+12 lines, -4 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM. As discussed offline, a separate CL should probably take care of a few NULL ...

6 years, 10 months ago (2014-01-29 09:31:30 UTC) #2

Benedikt Meurer

6 years, 10 months ago (2014-01-29 09:48:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r18897 (presubmit successful).