Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 148523005: This fixes debugging chrome apps from the dart editor. (Closed)

Created:
6 years, 10 months ago by Jacob
Modified:
6 years, 10 months ago
Reviewers:
vsm, devoncarew
CC:
reviews+dom_dartlang.org
Base URL:
http://src.chromium.org/chrome/branches/dart/1700/src/
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jacob
The dart editor cannot handle having chrome extensions running in Dartium. This removes the GoogleNow ...
6 years, 10 months ago (2014-01-28 02:04:57 UTC) #1
devoncarew
lgtm Thanks much for investigating! I did try disabling google now in dartium. It doesn't ...
6 years, 10 months ago (2014-01-28 03:21:26 UTC) #2
Jacob
6 years, 10 months ago (2014-01-28 20:12:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r247491.

Powered by Google App Engine
This is Rietveld 408576698