Eliminate ProfileOAuth2TokenService being a BCKS.

chrome/browser/signin/fake_profile_oauth2_token_service.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SIGNIN_FAKE_PROFILE_OAUTH2_TOKEN_SERVICE_H_
 #define CHROME_BROWSER_SIGNIN_FAKE_PROFILE_OAUTH2_TOKEN_SERVICE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 92 matching lines @@
                                        const base::Time& expiration);
 
   void IssueErrorForAllPendingRequests(const GoogleServiceAuthError& error);
 
   void set_auto_post_fetch_response_on_message_loop(bool auto_post_response) {
     auto_post_fetch_response_on_message_loop_ = auto_post_response;
   }
 
   // Helper function to be used with
   // BrowserContextKeyedService::SetTestingFactory().
-  static BrowserContextKeyedService* Build(content::BrowserContext* profile);
+  static BrowserContextKeyedService* Build(content::BrowserContext* context);

[blundell, 2014/02/10 16:19:16]

These functions should move to be on the FakePO2TSWrapper. Should I do that in
this CL do you think?

[Roger Tawa OOO till Jul 10th, 2014/02/10 19:49:13]

Probably makes sense to do it as part of this CL, since its about adding the new
layer of indirection.  Otherwise its a TODO that we'll need schedule later.

[blundell, 2014/02/13 16:07:06]

Done.

 
   // Helper function to be used with
   // BrowserContextKeyedService::SetTestingFactory() that creates a
   // FakeProfileOAuth2TokenService object that posts fetch responses on the
   // current message loop.
   static BrowserContextKeyedService* BuildAutoIssuingTokenService(
-      content::BrowserContext* profile);
+      content::BrowserContext* context);
 
  protected:
   // OAuth2TokenService overrides.
   virtual void FetchOAuth2Token(RequestImpl* request,
                                 const std::string& account_id,
                                 net::URLRequestContextGetter* getter,
                                 const std::string& client_id,
                                 const std::string& client_secret,
                                 const ScopeSet& scopes) OVERRIDE;
 
@@ skipping 24 matching lines @@
 
   // If true, then this fake service will post responses to
   // |FetchOAuth2Token| on the current run loop. There is no need to call
   // |IssueTokenForScope| in this case.
   bool auto_post_fetch_response_on_message_loop_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeProfileOAuth2TokenService);
 };
 
 #endif  // CHROME_BROWSER_SIGNIN_FAKE_PROFILE_OAUTH2_TOKEN_SERVICE_H_