Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 148513009: A64: Avoid generating simulator specific instructions if we are building a snapshot. (Closed)

Created:
6 years, 10 months ago by rmcilroy
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Avoid generating simulator specific instructions if we are building a snapshot. R=jochen@chromium.org, rodolph.perfetta@arm.com Committed: https://code.google.com/p/v8/source/detail?r=19243

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fallthrough if serializer is enabled. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M src/a64/assembler-a64.cc View 1 1 chunk +29 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmcilroy
This is the last piece in the puzzle of getting A64 V8 building for Android. ...
6 years, 10 months ago (2014-02-10 14:51:42 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-10 14:53:07 UTC) #2
Rodolph Perfetta (ARM)
LGTM with nit addressed. https://codereview.chromium.org/148513009/diff/1/src/a64/assembler-a64.cc File src/a64/assembler-a64.cc (right): https://codereview.chromium.org/148513009/diff/1/src/a64/assembler-a64.cc#newcode1793 src/a64/assembler-a64.cc:1793: return; not necessary.
6 years, 10 months ago (2014-02-10 15:18:18 UTC) #3
rmcilroy
I've update a new patch-set - PTAL. https://codereview.chromium.org/148513009/diff/1/src/a64/assembler-a64.cc File src/a64/assembler-a64.cc (right): https://codereview.chromium.org/148513009/diff/1/src/a64/assembler-a64.cc#newcode1793 src/a64/assembler-a64.cc:1793: return; On ...
6 years, 10 months ago (2014-02-10 16:18:32 UTC) #4
Rodolph Perfetta (ARM)
lgtm
6 years, 10 months ago (2014-02-10 20:16:38 UTC) #5
rmcilroy
6 years, 10 months ago (2014-02-10 21:33:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r19243 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698