Issue 148513002: android envsetup: Stop setting ORDER_DEFINES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148513002: android envsetup: Stop setting ORDER_DEFINES. (Closed)

Created:
6 years, 10 months ago by Nico

Modified:
6 years, 10 months ago

Reviewers:
Yaron, Torne

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android envsetup: Stop setting ORDER_DEFINES. order_text_section is only used by the chrome_initial target, which isn't used on android. (Some internal gyp file explicitly adds -Wl,-section-ordering-file without going through the order_text_section gyp define, so this setting here is likely a remnant from when that wasn't the case.) No intended behavior change. BUG=330631 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247283