Issue 14851009: Fix bindings tests after r149858

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14851009: Fix bindings tests after r149858 (Closed)

Created:
7 years, 7 months ago by do-not-use

Modified:
7 years, 7 months ago

Reviewers:
haraken

CC:
blink-reviews, Nate Chapin, jsbell+bindings_chromium.org, abarth-chromium, lgombos

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Fix bindings tests after r149858 r149858 caused the bindings tests to fail as the preprocess-idls.pl now requires an additional --windowConstructorsFile argument. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149871

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	Source/bindings/scripts/preprocess-idls.pl	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Tools/Scripts/webkitpy/bindings/main.py	View		3 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14851009/1

7 years, 7 months ago (2013-05-07 13:36:24 UTC) #3

Message was sent while issue was closed.

Change committed as 149871