Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: ui/message_center/message_center_impl.cc

Issue 1485093003: ui: use base's ContainsValue helper function instead of std::find (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/message_center/message_center_impl.cc
diff --git a/ui/message_center/message_center_impl.cc b/ui/message_center/message_center_impl.cc
index 5b7d4c0197a99319382844a0dddcc3e0096ae828..cf895b969414a72ffe982f5fc53d202b0caf1d41 100644
--- a/ui/message_center/message_center_impl.cc
+++ b/ui/message_center/message_center_impl.cc
@@ -10,6 +10,7 @@
#include "base/command_line.h"
#include "base/memory/scoped_vector.h"
#include "base/observer_list.h"
+#include "base/stl_util.h"
#include "ui/message_center/message_center_style.h"
#include "ui/message_center/message_center_switches.h"
#include "ui/message_center/message_center_types.h"
@@ -381,8 +382,7 @@ void MessageCenterImpl::RemoveObserver(MessageCenterObserver* observer) {
}
void MessageCenterImpl::AddNotificationBlocker(NotificationBlocker* blocker) {
- if (std::find(blockers_.begin(), blockers_.end(), blocker) !=
- blockers_.end()) {
+ if (ContainsValue(blockers_, blocker)) {
sky 2015/12/01 22:08:31 nit: nuke {}
tfarina 2015/12/02 20:31:41 Done.
return;
}
blocker->AddObserver(this);

Powered by Google App Engine
This is Rietveld 408576698