Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Issue 1485053002: [cleanup] Remove modules-related cruft from Scope (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
Reviewers:
Dan Ehrenberg, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Remove modules-related cruft from Scope These bits were relevant back when we had nested lexical modules, but I don't think they'll be of any use for ES2015 modules. Committed: https://crrev.com/b2ad33c2d2a8fbcce0b121a6de03d9e38fb3780f Cr-Commit-Position: refs/heads/master@{#32534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -44 lines) Patch
M src/ast/ast-value-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/scopes.h View 3 chunks +0 lines, -13 lines 0 comments Download
M src/ast/scopes.cc View 3 chunks +2 lines, -27 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
adamk
More cleanup. One of those days, I guess.
5 years ago (2015-12-01 01:25:17 UTC) #2
adamk
+littledan
5 years ago (2015-12-02 22:25:03 UTC) #4
Dan Ehrenberg
lgtm
5 years ago (2015-12-02 22:37:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485053002/1
5 years ago (2015-12-02 22:39:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/12518)
5 years ago (2015-12-02 22:47:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485053002/1
5 years ago (2015-12-02 22:54:15 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/12598)
5 years ago (2015-12-02 23:09:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485053002/1
5 years ago (2015-12-02 23:12:05 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 23:28:51 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-02 23:29:02 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2ad33c2d2a8fbcce0b121a6de03d9e38fb3780f
Cr-Commit-Position: refs/heads/master@{#32534}

Powered by Google App Engine
This is Rietveld 408576698