Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: media/video/video_decode_accelerator.h

Issue 1485043002: Passed is_encrypted parameter to the VDA initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/video_decode_accelerator.h
diff --git a/media/video/video_decode_accelerator.h b/media/video/video_decode_accelerator.h
index e2bcdf64855fdf3455fc0a3b73ae2b59c2e928e6..fd5bd6cdce4684b773435e7e02ed1f65be2dad29 100644
--- a/media/video/video_decode_accelerator.h
+++ b/media/video/video_decode_accelerator.h
@@ -53,6 +53,14 @@ class MEDIA_EXPORT VideoDecodeAccelerator {
LARGEST_ERROR_ENUM,
};
+ // Parameters required for the Initialize().
+ struct MEDIA_EXPORT InitParams {
+ InitParams(VideoCodecProfile profile = VIDEO_CODEC_PROFILE_UNKNOWN,
+ bool is_encrypted = false);
dcheng 2015/12/01 02:03:13 The style guide forbids default args.
+ VideoCodecProfile profile;
+ bool is_encrypted;
+ };
+
// Interface for collaborating with picture interface to provide memory for
// output picture and blitting them. These callbacks will not be made unless
// Initialize() has returned successfully.
@@ -111,10 +119,10 @@ class MEDIA_EXPORT VideoDecodeAccelerator {
// attached can we start to decode.
//
// Parameters:
- // |profile| is the video stream's format profile.
+ // |params| are the initialization parameters.
// |client| is the client of this video decoder. Does not take ownership of
// |client| which must be valid until Destroy() is called.
- virtual bool Initialize(VideoCodecProfile profile, Client* client) = 0;
+ virtual bool Initialize(const InitParams& params, Client* client) = 0;
// Sets a CDM to be used by the decoder to decode encrypted buffers.
// Client::NotifyCdmAttached() will then be called to indicate whether the CDM

Powered by Google App Engine
This is Rietveld 408576698