Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1485013002: Remove vector_as_array. (Closed)

Created:
5 years ago by davidben
Modified:
5 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, vmpstr+watch_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove vector_as_array. Everything is using std::vector::data now. BUG=556678 Committed: https://crrev.com/49889f708ee142d4d38d02b4d5d3570e86db6e78 Cr-Commit-Position: refs/heads/master@{#362334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M base/stl_util.h View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
davidben
5 years ago (2015-12-01 00:52:19 UTC) #2
Mark Mentovai
LGTM
5 years ago (2015-12-01 02:01:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485013002/1
5 years ago (2015-12-01 02:26:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 03:45:12 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/49889f708ee142d4d38d02b4d5d3570e86db6e78 Cr-Commit-Position: refs/heads/master@{#362334}
5 years ago (2015-12-01 03:45:48 UTC) #8
danakj
5 years ago (2015-12-01 19:07:12 UTC) #9
Message was sent while issue was closed. 
Thanks!

Powered by Google App Engine
This is Rietveld 408576698