Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 14850023: MIPS: Error found in test262 on ARM: BinaryOpStub could call out to a built-in and push parameters … (Closed)

Created:
7 years, 7 months ago by palfia
Modified:
7 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Error found in test262 on ARM: BinaryOpStub could call out to a built-in and push parameters without an enclosing frame. Port r14665 (15349aa) This corrupted stackwalking. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14673

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -18 lines) Patch
M src/mips/code-stubs-mips.h View 2 chunks +8 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 9 chunks +67 lines, -14 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
palfia
7 years, 7 months ago (2013-05-15 00:12:57 UTC) #1
Paul Lind
LGTM, once you fix the nits. https://codereview.chromium.org/14850023/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/14850023/diff/1/src/mips/code-stubs-mips.cc#newcode6494 src/mips/code-stubs-mips.cc:6494: // Build a ...
7 years, 7 months ago (2013-05-15 00:31:24 UTC) #2
palfia
Fixed nits. https://codereview.chromium.org/14850023/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/14850023/diff/1/src/mips/code-stubs-mips.cc#newcode6494 src/mips/code-stubs-mips.cc:6494: // Build a frame On 2013/05/15 00:31:24, ...
7 years, 7 months ago (2013-05-15 00:55:31 UTC) #3
Paul Lind
lgtm
7 years, 7 months ago (2013-05-15 00:56:40 UTC) #4
palfia
7 years, 7 months ago (2013-05-15 00:57:27 UTC) #5
Message was sent while issue was closed.
Committed manually as r14673 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698