Issue 14850020: Merge 199109 "Make cloud print dialog work with cloud printer on..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14850020: Merge 199109 "Make cloud print dialog work with cloud printer on..." (Closed)

Created:
7 years, 7 months ago by Vitaly Buka (NO REVIEWS)

Modified:
7 years, 7 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

Merge 199109 "Make cloud print dialog work with cloud printer on..." > Make cloud print dialog work with cloud printer on first signin. > Better check for current URL. > Assign data only to cloud print URLs. > Don't reset data_. > > BUG=236786 > > Review URL: https://chromiumcodereview.appspot.com/14864005 TBR=vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200057

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -23 lines)			Patch
	M	chrome/browser/printing/print_dialog_cloud.cc	View		6 chunks	+19 lines, -23 lines	0 comments	Download
	M	chrome/browser/printing/print_dialog_cloud_internal.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Vitaly Buka (NO REVIEWS)

7 years, 7 months ago (2013-05-14 20:32:57 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r200057.