Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 14850016: Don't use anonymous types declared in an anonymous union. (Closed)

Created:
7 years, 7 months ago by Sven Panne
Modified:
7 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Don't use anonymous types declared in an anonymous union. They are a non-standard extension (probably in C1X, IIRC), but clang is unhappy with them when -Wnested-anon-types is enabled, which seems to be implied by -pedantic. With this change and the previous fix for clang, we are now -Werror clean, even on clang 3.3. R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M include/v8.h View 1 chunk +19 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
Note that I've used two redudant "struct"s, keeping the "true C spirit". ;-)
7 years, 7 months ago (2013-05-14 11:53:06 UTC) #1
rossberg
lgtm
7 years, 7 months ago (2013-05-14 11:54:48 UTC) #2
Sven Panne
7 years, 7 months ago (2013-05-14 12:04:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14659 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698