Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 14850013: Fix occasional crash when lithium goes out of vregs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 return instr; 678 return instr;
679 } 679 }
680 680
681 681
682 LUnallocated* LChunkBuilder::TempRegister() { 682 LUnallocated* LChunkBuilder::TempRegister() {
683 LUnallocated* operand = 683 LUnallocated* operand =
684 new(zone()) LUnallocated(LUnallocated::MUST_HAVE_REGISTER); 684 new(zone()) LUnallocated(LUnallocated::MUST_HAVE_REGISTER);
685 int vreg = allocator_->GetVirtualRegister(); 685 int vreg = allocator_->GetVirtualRegister();
686 if (!allocator_->AllocationOk()) { 686 if (!allocator_->AllocationOk()) {
687 Abort("Out of virtual registers while trying to allocate temp register."); 687 Abort("Out of virtual registers while trying to allocate temp register.");
688 return NULL; 688 vreg = 0;
689 } 689 }
690 operand->set_virtual_register(vreg); 690 operand->set_virtual_register(vreg);
691 return operand; 691 return operand;
692 } 692 }
693 693
694 694
695 LOperand* LChunkBuilder::FixedTemp(Register reg) { 695 LOperand* LChunkBuilder::FixedTemp(Register reg) {
696 LUnallocated* operand = ToUnallocated(reg); 696 LUnallocated* operand = ToUnallocated(reg);
697 ASSERT(operand->HasFixedPolicy()); 697 ASSERT(operand->HasFixedPolicy());
698 return operand; 698 return operand;
(...skipping 1857 matching lines...) Expand 10 before | Expand all | Expand 10 after
2556 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2556 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2557 LOperand* object = UseRegister(instr->object()); 2557 LOperand* object = UseRegister(instr->object());
2558 LOperand* index = UseTempRegister(instr->index()); 2558 LOperand* index = UseTempRegister(instr->index());
2559 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2559 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2560 } 2560 }
2561 2561
2562 2562
2563 } } // namespace v8::internal 2563 } } // namespace v8::internal
2564 2564
2565 #endif // V8_TARGET_ARCH_X64 2565 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698