Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 14850013: Fix occasional crash when lithium goes out of vregs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 659 matching lines...) Expand 10 before | Expand all | Expand 10 after
670 return instr; 670 return instr;
671 } 671 }
672 672
673 673
674 LUnallocated* LChunkBuilder::TempRegister() { 674 LUnallocated* LChunkBuilder::TempRegister() {
675 LUnallocated* operand = 675 LUnallocated* operand =
676 new(zone()) LUnallocated(LUnallocated::MUST_HAVE_REGISTER); 676 new(zone()) LUnallocated(LUnallocated::MUST_HAVE_REGISTER);
677 int vreg = allocator_->GetVirtualRegister(); 677 int vreg = allocator_->GetVirtualRegister();
678 if (!allocator_->AllocationOk()) { 678 if (!allocator_->AllocationOk()) {
679 Abort("Out of virtual registers while trying to allocate temp register."); 679 Abort("Out of virtual registers while trying to allocate temp register.");
680 return NULL; 680 vreg = 0;
681 } 681 }
682 operand->set_virtual_register(vreg); 682 operand->set_virtual_register(vreg);
683 return operand; 683 return operand;
684 } 684 }
685 685
686 686
687 LOperand* LChunkBuilder::FixedTemp(Register reg) { 687 LOperand* LChunkBuilder::FixedTemp(Register reg) {
688 LUnallocated* operand = ToUnallocated(reg); 688 LUnallocated* operand = ToUnallocated(reg);
689 ASSERT(operand->HasFixedPolicy()); 689 ASSERT(operand->HasFixedPolicy());
690 return operand; 690 return operand;
(...skipping 1805 matching lines...) Expand 10 before | Expand all | Expand 10 after
2496 2496
2497 2497
2498 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2498 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2499 LOperand* object = UseRegister(instr->object()); 2499 LOperand* object = UseRegister(instr->object());
2500 LOperand* index = UseRegister(instr->index()); 2500 LOperand* index = UseRegister(instr->index());
2501 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2501 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2502 } 2502 }
2503 2503
2504 2504
2505 } } // namespace v8::internal 2505 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698