Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 14850013: Fix occasional crash when lithium goes out of vregs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 718 matching lines...) Expand 10 before | Expand all | Expand 10 after
729 return instr; 729 return instr;
730 } 730 }
731 731
732 732
733 LUnallocated* LChunkBuilder::TempRegister() { 733 LUnallocated* LChunkBuilder::TempRegister() {
734 LUnallocated* operand = 734 LUnallocated* operand =
735 new(zone()) LUnallocated(LUnallocated::MUST_HAVE_REGISTER); 735 new(zone()) LUnallocated(LUnallocated::MUST_HAVE_REGISTER);
736 int vreg = allocator_->GetVirtualRegister(); 736 int vreg = allocator_->GetVirtualRegister();
737 if (!allocator_->AllocationOk()) { 737 if (!allocator_->AllocationOk()) {
738 Abort("Out of virtual registers while trying to allocate temp register."); 738 Abort("Out of virtual registers while trying to allocate temp register.");
739 return NULL; 739 vreg = 0;
740 } 740 }
741 operand->set_virtual_register(vreg); 741 operand->set_virtual_register(vreg);
742 return operand; 742 return operand;
743 } 743 }
744 744
745 745
746 LOperand* LChunkBuilder::FixedTemp(Register reg) { 746 LOperand* LChunkBuilder::FixedTemp(Register reg) {
747 LUnallocated* operand = ToUnallocated(reg); 747 LUnallocated* operand = ToUnallocated(reg);
748 ASSERT(operand->HasFixedPolicy()); 748 ASSERT(operand->HasFixedPolicy());
749 return operand; 749 return operand;
(...skipping 2015 matching lines...) Expand 10 before | Expand all | Expand 10 after
2765 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2765 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2766 LOperand* object = UseRegister(instr->object()); 2766 LOperand* object = UseRegister(instr->object());
2767 LOperand* index = UseTempRegister(instr->index()); 2767 LOperand* index = UseTempRegister(instr->index());
2768 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2768 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2769 } 2769 }
2770 2770
2771 2771
2772 } } // namespace v8::internal 2772 } } // namespace v8::internal
2773 2773
2774 #endif // V8_TARGET_ARCH_IA32 2774 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698