Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: net/websockets/websocket_errors_unittest.cc

Issue 14850012: Add missing status codes to WebSocketError enum. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/websockets/websocket_errors_unittest.cc
diff --git a/net/websockets/websocket_errors_unittest.cc b/net/websockets/websocket_errors_unittest.cc
index f0e719d8d9809f32b41d81dc11ef13f413a4b6d5..6a5a269c80cc1141d34873ea21698c554774ad40 100644
--- a/net/websockets/websocket_errors_unittest.cc
+++ b/net/websockets/websocket_errors_unittest.cc
@@ -9,12 +9,21 @@
namespace net {
namespace {
+// Confirm that the principle classes of errors are converted correctly. We
+// don't exhaustively test every error code, as it would be long, repetitive,
+// and add little value.
TEST(WebSocketErrorToNetErrorTest, ResultsAreCorrect) {
- EXPECT_EQ(OK, WebSocketErrorToNetError(WEB_SOCKET_OK));
+ EXPECT_EQ(OK, WebSocketErrorToNetError(kWebSocketNormalClosure));
EXPECT_EQ(ERR_WS_PROTOCOL_ERROR,
- WebSocketErrorToNetError(WEB_SOCKET_ERR_PROTOCOL_ERROR));
+ WebSocketErrorToNetError(kWebSocketErrorProtocolError));
EXPECT_EQ(ERR_MSG_TOO_BIG,
- WebSocketErrorToNetError(WEB_SOCKET_ERR_MESSAGE_TOO_BIG));
+ WebSocketErrorToNetError(kWebSocketErrorMessageTooBig));
+ EXPECT_EQ(ERR_CONNECTION_CLOSED,
+ WebSocketErrorToNetError(kWebSocketErrorNoStatusReceived));
+ EXPECT_EQ(ERR_SSL_PROTOCOL_ERROR,
+ WebSocketErrorToNetError(kWebSocketErrorTlsHandshake));
+ EXPECT_EQ(ERR_WS_PROTOCOL_ERROR,
+ WebSocketErrorToNetError(kWebSocketErrorUnknownMuxOpcode));
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698