test/cctest/test-heap-profiler.cc - Issue 14850006: Use mutable heapnumbers to store doubles in fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 14850006: Use mutable heapnumbers to store doubles in fields. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-heap-profiler.cc

diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc

index 40ecc0252ff66d7c051176189da67c6f81849af8..b2c9b7220ec3938123f5bdb8df783a1db2eeeead 100644

--- a/test/cctest/test-heap-profiler.cc

+++ b/test/cctest/test-heap-profiler.cc

@@ -1414,7 +1414,7 @@ TEST(GetHeapValue) {

GetProperty(obj, v8::HeapGraphEdge::kProperty, "n_prop");

v8::Local<v8::Number> js_n_prop =

js_obj->Get(v8_str("n_prop")).As<v8::Number>();

- CHECK(js_n_prop == n_prop->GetHeapValue());

+ CHECK(js_n_prop->NumberValue() == n_prop->GetHeapValue()->NumberValue());

}