[Offline pages] Making sure visit button works on tablet

chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.enhancedbookmarks;
 
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
 import android.graphics.Bitmap;
 import android.net.Uri;
 import android.os.AsyncTask;
 import android.os.Bundle;
 import android.provider.Browser;
+import android.text.TextUtils;
 
 import org.chromium.base.ApiCompatibilityUtils;
+import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.base.metrics.RecordUserAction;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ChromeBrowserProviderClient;
 import org.chromium.chrome.browser.IntentHandler;
 import org.chromium.chrome.browser.UrlConstants;
 import org.chromium.chrome.browser.bookmark.BookmarksBridge;
 import org.chromium.chrome.browser.bookmark.BookmarksBridge.BookmarkItem;
 import org.chromium.chrome.browser.document.ChromeLauncherActivity;
 import org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarksModel.AddBookmarkCallback;
 import org.chromium.chrome.browser.favicon.FaviconHelper;
+import org.chromium.chrome.browser.ntp.NewTabPageUma;
 import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
 import org.chromium.chrome.browser.offlinepages.OfflinePageFreeUpSpaceCallback;
 import org.chromium.chrome.browser.offlinepages.OfflinePageFreeUpSpaceDialog;
 import org.chromium.chrome.browser.offlinepages.OfflinePageOpenStorageSettingsDialog;
 import org.chromium.chrome.browser.offlinepages.OfflinePageStorageSpacePolicy;
 import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
 import org.chromium.chrome.browser.snackbar.Snackbar;
 import org.chromium.chrome.browser.snackbar.SnackbarManager;
 import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
 import org.chromium.chrome.browser.tab.Tab;
@@ skipping 219 matching lines @@
 
     /**
      * Shows enhanced bookmark main UI, if it is turned on. Does nothing if it is turned off.
      * @return True if enhanced bookmark is on, false otherwise.
      */
     public static boolean showEnhancedBookmarkIfEnabled(Activity activity) {
         if (!isEnhancedBookmarkEnabled()) {
             return false;
         }
         if (DeviceFormFactor.isTablet(activity)) {
-            openBookmark(activity, UrlConstants.BOOKMARKS_URL);
+            openUrl(activity, UrlConstants.BOOKMARKS_URL);
         } else {
             activity.startActivity(new Intent(activity, EnhancedBookmarkActivity.class));
         }
         return true;
     }
 
     /**
      * Starts an {@link EnhancedBookmarkEditActivity} for the given {@link BookmarkId}.
      */
     public static void startEditActivity(
@@ skipping 35 matching lines @@
 
     /**
      * Retrieve the bookmark previously saved in the arguments bundle.
      * @param bundle Argument holder or savedInstanceState of the fragment/activity.
      * @return The ID of the bookmark to retrieve.
      */
     public static BookmarkId getBookmarkIdFromBundle(Bundle bundle) {
         return BookmarkId.getBookmarkIdFromString(bundle.getString(BOOKMARK_SAVE_NAME));
     }
 
-    public static void openBookmark(Activity activity, String url) {
+    /**
+     * Opens a bookmark depending on connection status and reports UMA.
+     * @param model Enhanced bookmarks model to manage the bookmark.
+     * @param activity Activity requesting to open the bookmark.
+     * @param bookmarkId ID of the bookmark to be opened.
+     * @param launchLocation Location from which the bookmark is being opened.
+     * @return Whether the bookmark was successfully opened.
+     */
+    public static boolean openBookmark(EnhancedBookmarksModel model, Activity activity,
+            BookmarkId bookmarkId, int launchLocation) {
+        if (model.getBookmarkById(bookmarkId) == null) return false;
+
+        String url = model.getLaunchUrlAndMarkAccessed(activity, bookmarkId);
+
+        // TODO(jianli): Notify the user about the failure.
+        if (TextUtils.isEmpty(url)) return false;
+
+        NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_BOOKMARK);
+        if (url.startsWith("file:")) {
+            RecordHistogram.recordEnumeratedHistogram(
+                    "OfflinePages.LaunchLocation", launchLocation, LaunchLocation.COUNT);
+        } else {
+            RecordHistogram.recordEnumeratedHistogram(
+                    "Stars.LaunchLocation", launchLocation, LaunchLocation.COUNT);
+        }
+
+        openUrl(activity, url);
+        return true;
+    }
+
+    private static void openUrl(Activity activity, String url) {
         Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
         intent.setClassName(activity.getApplicationContext().getPackageName(),
                 ChromeLauncherActivity.class.getName());
         intent.putExtra(Browser.EXTRA_APPLICATION_ID,
                 activity.getApplicationContext().getPackageName());
         intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
         IntentHandler.startActivityForTrustedIntent(intent, activity);
     }
 
     /**
@@ skipping 23 matching lines @@
 
     /**
      * Closes the EnhancedBookmark Activity on Phone. Does nothing on tablet.
      */
     public static void finishActivityOnPhone(Context context) {
         if (context instanceof EnhancedBookmarkActivity) {
             ((Activity) context).finish();
         }
     }
 }