Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: src/objects-inl.h

Issue 148493007: Don't unmark dictionary mode maps as unstable. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3970 matching lines...) Expand 10 before | Expand all | Expand 10 after
3981 set_bit_field3(IsShared::update(bit_field3(), value)); 3981 set_bit_field3(IsShared::update(bit_field3(), value));
3982 } 3982 }
3983 3983
3984 3984
3985 bool Map::is_shared() { 3985 bool Map::is_shared() {
3986 return IsShared::decode(bit_field3()); 3986 return IsShared::decode(bit_field3());
3987 } 3987 }
3988 3988
3989 3989
3990 void Map::set_dictionary_map(bool value) { 3990 void Map::set_dictionary_map(bool value) {
3991 if (value) mark_unstable(); 3991 uint32_t new_bit_field3 = DictionaryMap::update(bit_field3(), value);
3992 set_bit_field3(DictionaryMap::update(bit_field3(), value)); 3992 new_bit_field3 = IsUnstable::update(new_bit_field3, value);
3993 set_bit_field3(new_bit_field3);
3993 } 3994 }
3994 3995
3995 3996
3996 bool Map::is_dictionary_map() { 3997 bool Map::is_dictionary_map() {
3997 return DictionaryMap::decode(bit_field3()); 3998 return DictionaryMap::decode(bit_field3());
3998 } 3999 }
3999 4000
4000 4001
4001 Code::Flags Code::flags() { 4002 Code::Flags Code::flags() {
4002 return static_cast<Flags>(READ_INT_FIELD(this, kFlagsOffset)); 4003 return static_cast<Flags>(READ_INT_FIELD(this, kFlagsOffset));
(...skipping 2801 matching lines...) Expand 10 before | Expand all | Expand 10 after
6804 #undef READ_UINT32_FIELD 6805 #undef READ_UINT32_FIELD
6805 #undef WRITE_UINT32_FIELD 6806 #undef WRITE_UINT32_FIELD
6806 #undef READ_SHORT_FIELD 6807 #undef READ_SHORT_FIELD
6807 #undef WRITE_SHORT_FIELD 6808 #undef WRITE_SHORT_FIELD
6808 #undef READ_BYTE_FIELD 6809 #undef READ_BYTE_FIELD
6809 #undef WRITE_BYTE_FIELD 6810 #undef WRITE_BYTE_FIELD
6810 6811
6811 } } // namespace v8::internal 6812 } } // namespace v8::internal
6812 6813
6813 #endif // V8_OBJECTS_INL_H_ 6814 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698