Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: src/debug/debug.h

Issue 1484893003: [debugger] simplify reloc info for debug break slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/arm64/debug-arm64.cc ('k') | src/debug/debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.h
diff --git a/src/debug/debug.h b/src/debug/debug.h
index ab870f099092e29a5e29850479b8637e47154bb0..78b31352a7f553daff35edc3575ec65a85a35f0c 100644
--- a/src/debug/debug.h
+++ b/src/debug/debug.h
@@ -83,15 +83,6 @@ class BreakLocation {
inline bool IsCall() const {
return RelocInfo::IsDebugBreakSlotAtCall(rmode_);
}
- inline bool IsConstructCall() const {
- return RelocInfo::IsDebugBreakSlotAtConstructCall(rmode_);
- }
- inline int CallArgumentsCount() const {
- DCHECK(IsStepInLocation());
- return RelocInfo::DebugBreakCallArgumentsCount(data_);
- }
-
- bool IsStepInLocation() const;
inline bool HasBreakPoint() const {
return debug_info_->HasBreakPoint(pc_offset_);
}
@@ -775,8 +766,7 @@ class DebugCodegen : public AllStatic {
static void GenerateFrameDropperLiveEdit(MacroAssembler* masm);
- static void GenerateSlot(MacroAssembler* masm, RelocInfo::Mode mode,
- int call_argc = -1);
+ static void GenerateSlot(MacroAssembler* masm, RelocInfo::Mode mode);
static void PatchDebugBreakSlot(Isolate* isolate, Address pc,
Handle<Code> code);
« no previous file with comments | « src/debug/arm64/debug-arm64.cc ('k') | src/debug/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698