Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: src/mips64/assembler-mips64.cc

Issue 1484893003: [debugger] simplify reloc info for debug break slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips64/assembler-mips64.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 3088 matching lines...) Expand 10 before | Expand all | Expand 10 after
3099 *reinterpret_cast<uint64_t*>(pc_) = 3099 *reinterpret_cast<uint64_t*>(pc_) =
3100 reinterpret_cast<uint64_t>(stub->instruction_start()); 3100 reinterpret_cast<uint64_t>(stub->instruction_start());
3101 pc_ += sizeof(uint64_t); 3101 pc_ += sizeof(uint64_t);
3102 } 3102 }
3103 3103
3104 3104
3105 void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) { 3105 void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) {
3106 // We do not try to reuse pool constants. 3106 // We do not try to reuse pool constants.
3107 RelocInfo rinfo(isolate(), pc_, rmode, data, NULL); 3107 RelocInfo rinfo(isolate(), pc_, rmode, data, NULL);
3108 if (rmode >= RelocInfo::COMMENT && 3108 if (rmode >= RelocInfo::COMMENT &&
3109 rmode <= RelocInfo::DEBUG_BREAK_SLOT_AT_CONSTRUCT_CALL) { 3109 rmode <= RelocInfo::DEBUG_BREAK_SLOT_AT_CALL) {
3110 // Adjust code for new modes. 3110 // Adjust code for new modes.
3111 DCHECK(RelocInfo::IsDebugBreakSlot(rmode) 3111 DCHECK(RelocInfo::IsDebugBreakSlot(rmode)
3112 || RelocInfo::IsComment(rmode) 3112 || RelocInfo::IsComment(rmode)
3113 || RelocInfo::IsPosition(rmode)); 3113 || RelocInfo::IsPosition(rmode));
3114 // These modes do not need an entry in the constant pool. 3114 // These modes do not need an entry in the constant pool.
3115 } 3115 }
3116 if (!RelocInfo::IsNone(rinfo.rmode())) { 3116 if (!RelocInfo::IsNone(rinfo.rmode())) {
3117 // Don't record external references unless the heap will be serialized. 3117 // Don't record external references unless the heap will be serialized.
3118 if (rmode == RelocInfo::EXTERNAL_REFERENCE && 3118 if (rmode == RelocInfo::EXTERNAL_REFERENCE &&
3119 !serializer_enabled() && !emit_debug_code()) { 3119 !serializer_enabled() && !emit_debug_code()) {
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
3275 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 3275 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
3276 Assembler::FlushICache(isolate, pc, 4 * Assembler::kInstrSize); 3276 Assembler::FlushICache(isolate, pc, 4 * Assembler::kInstrSize);
3277 } 3277 }
3278 } 3278 }
3279 3279
3280 3280
3281 } // namespace internal 3281 } // namespace internal
3282 } // namespace v8 3282 } // namespace v8
3283 3283
3284 #endif // V8_TARGET_ARCH_MIPS64 3284 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips64/assembler-mips64.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698