Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Side by Side Diff: src/debug/x64/debug-x64.cc

Issue 1484893003: [debugger] simplify reloc info for debug break slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/mips64/debug-mips64.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/assembler.h" 7 #include "src/assembler.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 10
11 11
12 namespace v8 { 12 namespace v8 {
13 namespace internal { 13 namespace internal {
14 14
15 #define __ ACCESS_MASM(masm) 15 #define __ ACCESS_MASM(masm)
16 16
17 17
18 void EmitDebugBreakSlot(MacroAssembler* masm) { 18 void EmitDebugBreakSlot(MacroAssembler* masm) {
19 Label check_codesize; 19 Label check_codesize;
20 __ bind(&check_codesize); 20 __ bind(&check_codesize);
21 __ Nop(Assembler::kDebugBreakSlotLength); 21 __ Nop(Assembler::kDebugBreakSlotLength);
22 DCHECK_EQ(Assembler::kDebugBreakSlotLength, 22 DCHECK_EQ(Assembler::kDebugBreakSlotLength,
23 masm->SizeOfCodeGeneratedSince(&check_codesize)); 23 masm->SizeOfCodeGeneratedSince(&check_codesize));
24 } 24 }
25 25
26 26
27 void DebugCodegen::GenerateSlot(MacroAssembler* masm, RelocInfo::Mode mode, 27 void DebugCodegen::GenerateSlot(MacroAssembler* masm, RelocInfo::Mode mode) {
28 int call_argc) {
29 // Generate enough nop's to make space for a call instruction. 28 // Generate enough nop's to make space for a call instruction.
30 masm->RecordDebugBreakSlot(mode, call_argc); 29 masm->RecordDebugBreakSlot(mode);
31 EmitDebugBreakSlot(masm); 30 EmitDebugBreakSlot(masm);
32 } 31 }
33 32
34 33
35 void DebugCodegen::ClearDebugBreakSlot(Isolate* isolate, Address pc) { 34 void DebugCodegen::ClearDebugBreakSlot(Isolate* isolate, Address pc) {
36 CodePatcher patcher(isolate, pc, Assembler::kDebugBreakSlotLength); 35 CodePatcher patcher(isolate, pc, Assembler::kDebugBreakSlotLength);
37 EmitDebugBreakSlot(patcher.masm()); 36 EmitDebugBreakSlot(patcher.masm());
38 } 37 }
39 38
40 39
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 } 137 }
139 138
140 const bool LiveEdit::kFrameDropperSupported = true; 139 const bool LiveEdit::kFrameDropperSupported = true;
141 140
142 #undef __ 141 #undef __
143 142
144 } // namespace internal 143 } // namespace internal
145 } // namespace v8 144 } // namespace v8
146 145
147 #endif // V8_TARGET_ARCH_X64 146 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/debug/mips64/debug-mips64.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698