build/config/android/BUILD.gn - Issue 1484883002: clang/arm: Push -no-integrated-as into the four targets that need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/android/BUILD.gn

Issue 1484883002: clang/arm: Push -no-integrated-as into the four targets that need it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/android/BUILD.gn

diff --git a/build/config/android/BUILD.gn b/build/config/android/BUILD.gn

index 570417b080bde70c27ce08ccb17efaef8cc3b5ad..cfbde79dbc54b597ff43b28b277994a17b4afa67 100644

--- a/build/config/android/BUILD.gn

+++ b/build/config/android/BUILD.gn

@@ -33,9 +33,9 @@ config("compiler") {

if (is_clang) {

rebased_android_toolchain_root =

rebase_path(android_toolchain_root, root_build_dir)

- if (current_cpu == "arm" || current_cpu == "mipsel") {

+ if (current_cpu == "mipsel") {

cflags += [

- # TODO(hans) Enable integrated-as (crbug.com/124610).

+ # TODO(gordanac) Enable integrated-as.

"-no-integrated-as",

"-B${rebased_android_toolchain_root}/bin", # Else /usr/bin/as gets picked up.

]

« no previous file with comments | « build/common.gypi ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »