Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: build/common.gypi

Issue 1484883002: clang/arm: Push -no-integrated-as into the four targets that need it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/android/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3963 matching lines...) Expand 10 before | Expand all | Expand 10 after
3974 '-march=<(arm_arch)', 3974 '-march=<(arm_arch)',
3975 ], 3975 ],
3976 'conditions': [ 3976 'conditions': [
3977 ['use_lto==1 or use_lto_o2==1', { 3977 ['use_lto==1 or use_lto_o2==1', {
3978 'ldflags': [ 3978 'ldflags': [
3979 '-march=<(arm_arch)', 3979 '-march=<(arm_arch)',
3980 ], 3980 ],
3981 }], 3981 }],
3982 ], 3982 ],
3983 }], 3983 }],
3984 ['clang==1 and OS!="android"', {
3985 'cflags': [
3986 # We need to disable clang's builtin assembler as it can't
3987 # handle several asm files, crbug.com/124610
3988 '-no-integrated-as',
3989 ],
3990 }],
3991 ['arm_tune!=""', { 3984 ['arm_tune!=""', {
3992 'cflags': [ 3985 'cflags': [
3993 '-mtune=<(arm_tune)', 3986 '-mtune=<(arm_tune)',
3994 ], 3987 ],
3995 'conditions': [ 3988 'conditions': [
3996 ['use_lto==1 or use_lto_o2==1', { 3989 ['use_lto==1 or use_lto_o2==1', {
3997 'ldflags': [ 3990 'ldflags': [
3998 '-mtune=<(arm_tune)', 3991 '-mtune=<(arm_tune)',
3999 ], 3992 ],
4000 }], 3993 }],
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
4094 ['clang==1', { 4087 ['clang==1', {
4095 'cflags!': [ 4088 'cflags!': [
4096 # Clang does not support the following options. 4089 # Clang does not support the following options.
4097 '-mapcs-frame', 4090 '-mapcs-frame',
4098 '-mthumb-interwork', 4091 '-mthumb-interwork',
4099 '-finline-limit=64', 4092 '-finline-limit=64',
4100 '-fno-tree-sra', 4093 '-fno-tree-sra',
4101 '-fno-caller-saves', 4094 '-fno-caller-saves',
4102 '-Wno-psabi', 4095 '-Wno-psabi',
4103 ], 4096 ],
4104 'cflags': [
4105 # TODO(hans) Enable integrated-as (crbug.com/124610).
4106 '-no-integrated-as',
4107 '-B<(android_toolchain)', # Else /usr/bin/as gets pic ked up.
4108 ],
4109 }], 4097 }],
4110 ['clang==1 and linux_use_bundled_gold==0', { 4098 ['clang==1 and linux_use_bundled_gold==0', {
4111 'ldflags': [ 4099 'ldflags': [
4112 # Let clang find the ld.gold in the NDK. 4100 # Let clang find the ld.gold in the NDK.
4113 '--gcc-toolchain=<(android_toolchain)/..', 4101 '--gcc-toolchain=<(android_toolchain)/..',
4114 ], 4102 ],
4115 }], 4103 }],
4116 ['asan==1', { 4104 ['asan==1', {
4117 'cflags': [ 4105 'cflags': [
4118 '-marm', # Required for frame pointer based stack trac es. 4106 '-marm', # Required for frame pointer based stack trac es.
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
4222 'cflags!': [ 4210 'cflags!': [
4223 # Clang does not support the following options. 4211 # Clang does not support the following options.
4224 '-finline-limit=64', 4212 '-finline-limit=64',
4225 ], 4213 ],
4226 'cflags': [ 4214 'cflags': [
4227 # TODO(gordanac) Enable integrated-as. 4215 # TODO(gordanac) Enable integrated-as.
4228 '-no-integrated-as', 4216 '-no-integrated-as',
4229 ], 4217 ],
4230 }], 4218 }],
4231 ['clang==1 and OS=="android"', { 4219 ['clang==1 and OS=="android"', {
4232 'cflags': [
4233 '-B<(android_toolchain)', # Else /usr/bin/as gets picked up.
4234 ],
4235 'ldflags': [ 4220 'ldflags': [
4236 # Let clang find the ld in the NDK. 4221 # Let clang find the ld in the NDK.
4237 '--gcc-toolchain=<(android_toolchain)/..', 4222 '--gcc-toolchain=<(android_toolchain)/..',
4238 ], 4223 ],
4239 }], 4224 }],
4240 ['mips_dsp_rev==1', { 4225 ['mips_dsp_rev==1', {
4241 'cflags': ['-mdsp'], 4226 'cflags': ['-mdsp'],
4242 }], 4227 }],
4243 ['mips_dsp_rev==2', { 4228 ['mips_dsp_rev==2', {
4244 'cflags': ['-mdspr2'], 4229 'cflags': ['-mdspr2'],
(...skipping 2118 matching lines...) Expand 10 before | Expand all | Expand 10 after
6363 # settings in target dicts. SYMROOT is a special case, because many other 6348 # settings in target dicts. SYMROOT is a special case, because many other
6364 # Xcode variables depend on it, including variables such as 6349 # Xcode variables depend on it, including variables such as
6365 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6350 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6366 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6351 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6367 # files to appear (when present) in the UI as actual files and not red 6352 # files to appear (when present) in the UI as actual files and not red
6368 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6353 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6369 # and therefore SYMROOT, needs to be set at the project level. 6354 # and therefore SYMROOT, needs to be set at the project level.
6370 'SYMROOT': '<(DEPTH)/xcodebuild', 6355 'SYMROOT': '<(DEPTH)/xcodebuild',
6371 }, 6356 },
6372 } 6357 }
OLDNEW
« no previous file with comments | « no previous file | build/config/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698