third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp - Issue 1484853003: Ganesh: images upload to GPU performance fix (skip copying encoded data)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

Issue 1484853003: Ganesh: images upload to GPU performance fix (skip copying encoded data) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase to gtest update Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h » ('j') | third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

index cd34b54fce2c9e1f6bd72e18027b61b6d1c28352..6fe292603df5e86f5f5a14362a739b415d90a207 100644

--- a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

@@ -51,16 +51,7 @@ DecodingImageGenerator::~DecodingImageGenerator()

SkData* DecodingImageGenerator::onRefEncodedData()

{

TRACE_EVENT0("blink", "DecodingImageGenerator::refEncodedData");

- // FIXME: If the image has been clipped or scaled, do not return the original

- // encoded data, since on playback it will not be known how the clipping/scaling

- // was done.

- RefPtr<SharedBuffer> buffer = nullptr;

- bool allDataReceived = false;

- m_frameGenerator->copyData(&buffer, &allDataReceived);

- if (buffer && allDataReceived)

- return SkData::NewWithCopy(buffer->data(), buffer->size());

- return 0;

+ return m_frameGenerator->refEncodedData();

Noel Gordon 2015/12/08 15:41:58 Space before this line, as done elsewhere in this

aleksandar.stojiljkovic 2015/12/08 20:28:13 Done.

}

bool DecodingImageGenerator::onGetPixels(const SkImageInfo& info, void* pixels, size_t rowBytes,