third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.h - Issue 1484853003: Ganesh: images upload to GPU performance fix (skip copying encoded data)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.h

Issue 1484853003: Ganesh: images upload to GPU performance fix (skip copying encoded data) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review update, assert for appending data to m_allDataReceived Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp ('K') | « third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp ('k') | third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.h

diff --git a/third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.h b/third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.h

index 9fdea6c0ee2bc0e6fc7d4a7844dd81c2610669a3..a5a03189d747366fd14a4ecf6c01a000f8b55b1c 100644

--- a/third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.h

+++ b/third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.h

@@ -63,6 +63,7 @@ private:

Mutex m_mutex;

Vector<RefPtr<SharedBuffer>> m_newBufferQueue;

+ bool m_newAllDataReceived;

chrishtr 2015/12/02 16:44:29 How about m_allDataReceivedForNewBufferQueue. Long

scroggo_chromium 2015/12/02 20:15:01 +1. I find m_newAllDataReceived confusing.

RefPtr<SharedBuffer> m_readBuffer;

bool m_allDataReceived;

size_t m_readPosition;