third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h - Issue 1484853003: Ganesh: images upload to GPU performance fix (skip copying encoded data)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h

Issue 1484853003: Ganesh: images upload to GPU performance fix (skip copying encoded data) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review update, assert for appending data to m_allDataReceived Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp ('k') | third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp » ('j') | third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h

diff --git a/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h b/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h

index 39d3c40b00713a5849d327db5aa0bc9b17454317..4f2e2c851556882b22e138142b82129baa2cd361 100644

--- a/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h

+++ b/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h

@@ -27,6 +27,7 @@

#define ImageFrameGenerator_h

#include "SkBitmap.h"

+#include "SkData.h"

#include "SkSize.h"

#include "SkTypes.h"

#include "platform/PlatformExport.h"

@@ -75,8 +76,9 @@ public:

void setData(PassRefPtr<SharedBuffer>, bool allDataReceived);

- // Creates a new SharedBuffer containing the data received so far.

- void copyData(RefPtr<SharedBuffer>*, bool* allDataReceived);

+ // Returns pointer to SkData. Caller needs to unref it, according to contract in

+ // SkImageGenerator::refEncodedData.

+ SkData* refSkData();

SkISize getFullSize() const { return m_fullSize; }