Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1484843002: Tidy ifdefs in fpdfsdk. (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Tidy PDF_ENABLE_XFA #ifdefs in fpdfsdk. -- label matching #endifs -- prefer #ifdef over #ifndef -- consolidate some blocks. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/40e9ff30b7f22b37c071dc9751f489d4cc22b0ee

Patch Set 1 #

Patch Set 2 : Finish #

Total comments: 2

Patch Set 3 : Fix initialization error warning. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -516 lines) Patch
M fpdfsdk/include/formfiller/FFL_ComboBox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_FormFiller.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_IFormFiller.h View 2 chunks +3 lines, -6 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_TextField.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 8 chunks +9 lines, -8 lines 0 comments Download
M fpdfsdk/include/fsdk_baseannot.h View 4 chunks +6 lines, -8 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 11 chunks +19 lines, -25 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 4 chunks +14 lines, -17 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 10 chunks +41 lines, -36 lines 0 comments Download
M fpdfsdk/include/javascript/IJavaScript.h View 2 chunks +5 lines, -4 lines 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ComboBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_ext.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 2 chunks +10 lines, -9 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 12 chunks +44 lines, -60 lines 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 1 9 chunks +6 lines, -15 lines 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 2 chunks +9 lines, -8 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 20 chunks +74 lines, -80 lines 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 1 14 chunks +18 lines, -24 lines 0 comments Download
M fpdfsdk/src/fsdk_baseannot.cpp View 1 3 chunks +11 lines, -12 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 2 33 chunks +41 lines, -81 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 19 chunks +61 lines, -75 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 2 chunks +5 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime_Stub.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp View 1 7 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
ochang@ please review in place of the OOO thestig@. Should be mechanical changes only, no ...
5 years ago (2015-11-30 19:06:22 UTC) #3
Oliver Chang
lgtm. feel free to ignore the very minor nits https://codereview.chromium.org/1484843002/diff/20001/fpdfsdk/src/fpdfformfill.cpp File fpdfsdk/src/fpdfformfill.cpp (right): https://codereview.chromium.org/1484843002/diff/20001/fpdfsdk/src/fpdfformfill.cpp#newcode310 fpdfsdk/src/fpdfformfill.cpp:310: ...
5 years ago (2015-11-30 19:33:19 UTC) #4
Tom Sepez
5 years ago (2015-11-30 20:39:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
40e9ff30b7f22b37c071dc9751f489d4cc22b0ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698