[SyncFS] Force activate folder tracker on folder creation conflict case

chrome/browser/sync_file_system/drive_backend/metadata_database.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_METADATA_DATABASE_H_
 #define CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_METADATA_DATABASE_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 107 matching lines @@
   typedef std::map<std::string, FileTracker*> TrackerByAppID;
   typedef std::vector<std::string> FileIDList;
 
   typedef base::Callback<
       void(SyncStatusCode status, scoped_ptr<MetadataDatabase> instance)>
       CreateCallback;
 
   enum ActivationStatus {
     ACTIVATION_PENDING,
     ACTIVATION_FAILED_ANOTHER_ACTIVE_TRACKER,
-    ACTIVATION_FAILED_SAME_PATH_TRACKER,
   };
 
   enum UpdateOption {
     UPDATE_TRACKER_FOR_UNSYNCED_FILE,
     UPDATE_TRACKER_FOR_SYNCED_FILE,
   };
 
   // The entry point of the MetadataDatabase for production code.
   // If |env_override| is non-NULL, internal LevelDB uses |env_override| instead
   // of leveldb::Env::Default().  Use leveldb::MemEnv in test code for faster
@@ skipping 159 matching lines @@
   void PopulateFolderByChildList(const std::string& folder_id,
                                  const FileIDList& child_file_ids,
                                  const SyncStatusCallback& callback);
 
   // Updates |synced_details| of the tracker with |updated_details|.
   void UpdateTracker(int64 tracker_id,
                      const FileDetails& updated_details,
                      const SyncStatusCallback& callback);
 
   // Returns ACTIVATION_PENDING if a tracker of the file can be safely activated
-  // without deactivating any other trackers.  In this case, tries to activate
-  // the tracker, and invokes |callback| upon completion.
+  // without deactivating any other path trackers.  In this case, tries to

[kinuko, 2014/02/06 09:48:01]

We never used the term 'path tracker', it's bit unclear

[tzik, 2014/02/07 04:43:53]

Revised these comment.

+  // activate the tracker, and invokes |callback| upon completion.
   // Returns ACTIVATION_FAILED_ANOTHER_ACTIVE_TRACKER if there's another active
   // tracker that tracks |file_id|.
-  // Returns ACTIVATION_FAILED_SAME_PATH_TRACKER if there's another active
-  // tracker that has the same parent tracker and title to |file_id|.
-  // In these FAILED cases, |callback| is not invoked.
+  // In the FAILED case, |callback| is not invoked.

[kinuko, 2014/02/06 09:48:01]

nit/suggestion: remove the line-break at the end of line 310, and change the
line 311 to just tell: '|callback| is not invoked in this case'

[tzik, 2014/02/07 04:43:53]

Done.

   ActivationStatus TryNoSideEffectActivation(

[nhiroki, 2014/02/06 10:02:42]

Can we reconsider this function name? In a specific case this deactivates a
tracker (that is "SideEffect)".

[tzik, 2014/02/07 04:43:53]

Done.

       int64 parent_tracker_id,
       const std::string& file_id,
       const SyncStatusCallback& callback);
 
   // Changes the priority of the tracker to low.
   void LowerTrackerPriority(int64 tracker_id);
   void PromoteLowerPriorityTrackersToNormal();
 
   // Returns true if there is a normal priority dirty tracker.
   // Assigns the dirty tracker if exists and |tracker| is non-NULL.
@@ skipping 176 matching lines @@
 
   base::WeakPtrFactory<MetadataDatabase> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MetadataDatabase);
 };
 
 }  // namespace drive_backend
 }  // namespace sync_file_system
 
 #endif  // CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_METADATA_DATABASE_H_