Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1484763003: ipc: Slight change to GetSenderWithProcessId(). (Closed)

Created:
5 years ago by erikchen
Modified:
5 years ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Slight change to GetSenderWithProcessId(). Previously, the implementation of the method acquired a lock. This means that the caller could not guarantee that the returned Sender was still valid. I changed the method to require that the caller acquire the lock, so that the caller can guarantee the validity of the returned Sender. BUG=561734 Committed: https://crrev.com/63c0fa2af4cf0072c04d5cdc6dedd59870cfbb42 Cr-Commit-Position: refs/heads/master@{#362223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M ipc/attachment_broker_privileged.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/attachment_broker_privileged.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/attachment_broker_privileged_mac.cc View 4 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
erikchen
tsepez: Please review.
5 years ago (2015-11-30 19:19:43 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484763003/1
5 years ago (2015-11-30 19:19:43 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-30 20:43:44 UTC) #7
Tom Sepez
lgtm
5 years ago (2015-11-30 21:00:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484763003/1
5 years ago (2015-11-30 21:05:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 21:21:19 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-30 21:22:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63c0fa2af4cf0072c04d5cdc6dedd59870cfbb42
Cr-Commit-Position: refs/heads/master@{#362223}

Powered by Google App Engine
This is Rietveld 408576698