Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1484743002: [XHR] Fix interactive-state.html layout test for the new ProgressEvent throttling algorithm (Closed)

Created:
5 years ago by tyoshino (SeeGerritForStatus)
Modified:
5 years ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[XHR] Fix interactive-state.html layout test for the new ProgressEvent throttling algorithm A new ProgressEvent throttling algorithm has been introduced by https://codereview.chromium.org/1455513002/ The new algorithm suppresses redundant "progress" ProgressEvents using 50 ms slot. Update the interactive-state.html test for the new algorithm. BUG=336066 R=yhirano Committed: https://crrev.com/30508d30a3ae392ecfb611ba42e2128e225c3c6a Cr-Commit-Position: refs/heads/master@{#362123}

Patch Set 1 #

Patch Set 2 : Changed sleep to 1 sec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/interactive-state.cgi View 1 2 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/interactive-state.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
tyoshino (SeeGerritForStatus)
5 years ago (2015-11-30 12:14:39 UTC) #3
yhirano
On 2015/11/30 12:14:39, tyoshino wrote: Is 0.2sec sufficient?
5 years ago (2015-11-30 12:19:36 UTC) #4
tyoshino (SeeGerritForStatus)
On 2015/11/30 12:19:36, yhirano wrote: > On 2015/11/30 12:14:39, tyoshino wrote: > > Is 0.2sec ...
5 years ago (2015-11-30 12:22:57 UTC) #5
tyoshino (SeeGerritForStatus)
On 2015/11/30 12:22:57, tyoshino wrote: > On 2015/11/30 12:19:36, yhirano wrote: > > On 2015/11/30 ...
5 years ago (2015-11-30 12:23:46 UTC) #6
tyoshino (SeeGerritForStatus)
On 2015/11/30 12:23:46, tyoshino wrote: > On 2015/11/30 12:22:57, tyoshino wrote: > > On 2015/11/30 ...
5 years ago (2015-11-30 12:36:02 UTC) #7
yhirano
On 2015/11/30 12:36:02, tyoshino wrote: > On 2015/11/30 12:23:46, tyoshino wrote: > > On 2015/11/30 ...
5 years ago (2015-11-30 12:36:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1484743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1484743002/20001
5 years ago (2015-11-30 13:00:00 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-30 13:43:49 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-30 13:45:04 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/30508d30a3ae392ecfb611ba42e2128e225c3c6a
Cr-Commit-Position: refs/heads/master@{#362123}

Powered by Google App Engine
This is Rietveld 408576698