src/compiler/js-typed-lowering.cc - Issue 1484723003: [runtime] Use "the hole" instead of smi 0 as sentinel for context extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 1484723003: [runtime] Use "the hole" instead of smi 0 as sentinel for context extension. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comment. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/js-typed-lowering.cc

diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc

index 1665c0738b5b0b9d04e66f52780c662d2868c710..0d63ebdf5cbca4718e83ea4b7eaf15ed62c2d0d9 100644

--- a/src/compiler/js-typed-lowering.cc

+++ b/src/compiler/js-typed-lowering.cc

@@ -1837,7 +1837,7 @@ Reduction JSTypedLowering::ReduceJSCreateFunctionContext(Node* node) {

Node* effect = NodeProperties::GetEffectInput(node);

Node* control = NodeProperties::GetControlInput(node);

Node* context = NodeProperties::GetContextInput(node);

- Node* extension = jsgraph()->ZeroConstant();

+ Node* extension = jsgraph()->TheHoleConstant();

Node* native_context = effect = graph()->NewNode(

javascript()->LoadContext(0, Context::NATIVE_CONTEXT_INDEX, true),

context, context, effect);

« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/compiler/typer.cc » ('j') | no next file with comments »