src/code-stubs-hydrogen.cc - Issue 1484723003: [runtime] Use "the hole" instead of smi 0 as sentinel for context extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/code-stubs-hydrogen.cc

Issue 1484723003: [runtime] Use "the hole" instead of smi 0 as sentinel for context extension. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comment. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/code-stubs-hydrogen.cc

diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc

index e4f75a4e0f2377bf69ed7c1f404c63141b3ab443..b39fdee2c354329e673eadbb273aacf24e8e0aab 100644

--- a/src/code-stubs-hydrogen.cc

+++ b/src/code-stubs-hydrogen.cc

@@ -2135,7 +2135,7 @@ HValue* CodeStubGraphBuilder<FastNewContextStub>::BuildCodeStub() {

context());

Add<HStoreNamedField>(function_context,

HObjectAccess::ForContextSlot(Context::EXTENSION_INDEX),

- graph()->GetConstant0());

+ graph()->GetConstantHole());

// Copy the native context from the previous context.

HValue* native_context = Add<HLoadNamedField>(

« no previous file with comments | « no previous file | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »