src/runtime/runtime-scopes.cc - Issue 1484723003: [runtime] Use "the hole" instead of smi 0 as sentinel for context extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-scopes.cc

Issue 1484723003: [runtime] Use "the hole" instead of smi 0 as sentinel for context extension. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-scopes.cc

diff --git a/src/runtime/runtime-scopes.cc b/src/runtime/runtime-scopes.cc

index a6c2c06ec9868e1c4600a2cf483393c4fc2eb4b7..5b4deb72287de8084acc25690dec89c28ed0fa17 100644

--- a/src/runtime/runtime-scopes.cc

+++ b/src/runtime/runtime-scopes.cc

@@ -294,7 +294,7 @@ Object* DeclareLookupSlot(Isolate* isolate, Handle<String> name,

DCHECK(context->IsBlockContext());

object = isolate->factory()->NewJSObject(

isolate->context_extension_function());

- Handle<Object> extension =

+ Handle<HeapObject> extension =

isolate->factory()->NewSloppyBlockWithEvalContextExtension(

handle(context->scope_info()), object);

context->set_extension(*extension);

@@ -306,7 +306,7 @@ Object* DeclareLookupSlot(Isolate* isolate, Handle<String> name,

DCHECK(context->IsFunctionContext());

object =

isolate->factory()->NewJSObject(isolate->context_extension_function());

- context->set_extension(*object);

+ context->set_extension(HeapObject::cast(*object));

Michael Starzinger 2015/11/30 13:02:48 nit: Explicit cast should not be necessary, as it

Benedikt Meurer 2015/11/30 13:04:20 Done.

}

RETURN_FAILURE_ON_EXCEPTION(isolate, JSObject::SetOwnPropertyIgnoreAttributes(

« no previous file with comments | « src/runtime/runtime-debug.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »