Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: src/profiler/heap-snapshot-generator.cc

Issue 1484723003: [runtime] Use "the hole" instead of smi 0 as sentinel for context extension. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comment. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/runtime/runtime-debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/profiler/heap-snapshot-generator.h" 5 #include "src/profiler/heap-snapshot-generator.h"
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/conversions.h" 8 #include "src/conversions.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/objects-body-descriptors.h" 10 #include "src/objects-body-descriptors.h"
(...skipping 1229 matching lines...) Expand 10 before | Expand all | Expand 10 after
1240 if (Context::index < Context::FIRST_WEAK_SLOT || \ 1240 if (Context::index < Context::FIRST_WEAK_SLOT || \
1241 Context::index == Context::MAP_CACHE_INDEX) { \ 1241 Context::index == Context::MAP_CACHE_INDEX) { \
1242 SetInternalReference(context, entry, #name, context->get(Context::index), \ 1242 SetInternalReference(context, entry, #name, context->get(Context::index), \
1243 FixedArray::OffsetOfElementAt(Context::index)); \ 1243 FixedArray::OffsetOfElementAt(Context::index)); \
1244 } else { \ 1244 } else { \
1245 SetWeakReference(context, entry, #name, context->get(Context::index), \ 1245 SetWeakReference(context, entry, #name, context->get(Context::index), \
1246 FixedArray::OffsetOfElementAt(Context::index)); \ 1246 FixedArray::OffsetOfElementAt(Context::index)); \
1247 } 1247 }
1248 EXTRACT_CONTEXT_FIELD(CLOSURE_INDEX, JSFunction, closure); 1248 EXTRACT_CONTEXT_FIELD(CLOSURE_INDEX, JSFunction, closure);
1249 EXTRACT_CONTEXT_FIELD(PREVIOUS_INDEX, Context, previous); 1249 EXTRACT_CONTEXT_FIELD(PREVIOUS_INDEX, Context, previous);
1250 EXTRACT_CONTEXT_FIELD(EXTENSION_INDEX, Object, extension); 1250 EXTRACT_CONTEXT_FIELD(EXTENSION_INDEX, HeapObject, extension);
1251 EXTRACT_CONTEXT_FIELD(NATIVE_CONTEXT_INDEX, Context, native_context); 1251 EXTRACT_CONTEXT_FIELD(NATIVE_CONTEXT_INDEX, Context, native_context);
1252 if (context->IsNativeContext()) { 1252 if (context->IsNativeContext()) {
1253 TagObject(context->normalized_map_cache(), "(context norm. map cache)"); 1253 TagObject(context->normalized_map_cache(), "(context norm. map cache)");
1254 TagObject(context->embedder_data(), "(context data)"); 1254 TagObject(context->embedder_data(), "(context data)");
1255 NATIVE_CONTEXT_FIELDS(EXTRACT_CONTEXT_FIELD) 1255 NATIVE_CONTEXT_FIELDS(EXTRACT_CONTEXT_FIELD)
1256 EXTRACT_CONTEXT_FIELD(OPTIMIZED_FUNCTIONS_LIST, unused, 1256 EXTRACT_CONTEXT_FIELD(OPTIMIZED_FUNCTIONS_LIST, unused,
1257 optimized_functions_list); 1257 optimized_functions_list);
1258 EXTRACT_CONTEXT_FIELD(OPTIMIZED_CODE_LIST, unused, optimized_code_list); 1258 EXTRACT_CONTEXT_FIELD(OPTIMIZED_CODE_LIST, unused, optimized_code_list);
1259 EXTRACT_CONTEXT_FIELD(DEOPTIMIZED_CODE_LIST, unused, deoptimized_code_list); 1259 EXTRACT_CONTEXT_FIELD(DEOPTIMIZED_CODE_LIST, unused, deoptimized_code_list);
1260 EXTRACT_CONTEXT_FIELD(NEXT_CONTEXT_LINK, unused, next_context_link); 1260 EXTRACT_CONTEXT_FIELD(NEXT_CONTEXT_LINK, unused, next_context_link);
(...skipping 1906 matching lines...) Expand 10 before | Expand all | Expand 10 after
3167 for (int i = 1; i < sorted_strings.length(); ++i) { 3167 for (int i = 1; i < sorted_strings.length(); ++i) {
3168 writer_->AddCharacter(','); 3168 writer_->AddCharacter(',');
3169 SerializeString(sorted_strings[i]); 3169 SerializeString(sorted_strings[i]);
3170 if (writer_->aborted()) return; 3170 if (writer_->aborted()) return;
3171 } 3171 }
3172 } 3172 }
3173 3173
3174 3174
3175 } // namespace internal 3175 } // namespace internal
3176 } // namespace v8 3176 } // namespace v8
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/runtime/runtime-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698