Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: src/compiler/typer.cc

Issue 1484723003: [runtime] Use "the hole" instead of smi 0 as sentinel for context extension. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comment. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/contexts.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/typer.h" 5 #include "src/compiler/typer.h"
6 6
7 #include "src/base/flags.h" 7 #include "src/base/flags.h"
8 #include "src/bootstrapper.h" 8 #include "src/bootstrapper.h"
9 #include "src/compilation-dependencies.h" 9 #include "src/compilation-dependencies.h"
10 #include "src/compiler/common-operator.h" 10 #include "src/compiler/common-operator.h"
(...skipping 1398 matching lines...) Expand 10 before | Expand all | Expand 10 after
1409 1409
1410 Type* Typer::Visitor::TypeJSInstanceOf(Node* node) { 1410 Type* Typer::Visitor::TypeJSInstanceOf(Node* node) {
1411 return Type::Boolean(zone()); 1411 return Type::Boolean(zone());
1412 } 1412 }
1413 1413
1414 1414
1415 // JS context operators. 1415 // JS context operators.
1416 1416
1417 1417
1418 Type* Typer::Visitor::TypeJSLoadContext(Node* node) { 1418 Type* Typer::Visitor::TypeJSLoadContext(Node* node) {
1419 ContextAccess const& access = ContextAccessOf(node->op());
1420 if (access.index() == Context::EXTENSION_INDEX) {
1421 return Type::TaggedPointer();
1422 }
1419 // Since contexts are mutable, we just return the top. 1423 // Since contexts are mutable, we just return the top.
1420 return Type::Any(); 1424 return Type::Any();
1421 } 1425 }
1422 1426
1423 1427
1424 Type* Typer::Visitor::TypeJSStoreContext(Node* node) { 1428 Type* Typer::Visitor::TypeJSStoreContext(Node* node) {
1425 UNREACHABLE(); 1429 UNREACHABLE();
1426 return nullptr; 1430 return nullptr;
1427 } 1431 }
1428 1432
(...skipping 984 matching lines...) Expand 10 before | Expand all | Expand 10 after
2413 } 2417 }
2414 if (Type::IsInteger(*value)) { 2418 if (Type::IsInteger(*value)) {
2415 return Type::Range(value->Number(), value->Number(), zone()); 2419 return Type::Range(value->Number(), value->Number(), zone());
2416 } 2420 }
2417 return Type::Constant(value, zone()); 2421 return Type::Constant(value, zone());
2418 } 2422 }
2419 2423
2420 } // namespace compiler 2424 } // namespace compiler
2421 } // namespace internal 2425 } // namespace internal
2422 } // namespace v8 2426 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/contexts.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698