Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3856)

Unified Diff: chromecast/crash/linux/minidump_writer_unittest.cc

Issue 1484713003: [Chromecast] Use ScopedTemp[File|Dir] in tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Style Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/crash/linux/minidump_writer_unittest.cc
diff --git a/chromecast/crash/linux/minidump_writer_unittest.cc b/chromecast/crash/linux/minidump_writer_unittest.cc
index ffb6eae12f3ad3826679ae64d969f68653610661..f9156f88d1d2d836240bec242e7f352d036f3865 100644
--- a/chromecast/crash/linux/minidump_writer_unittest.cc
+++ b/chromecast/crash/linux/minidump_writer_unittest.cc
@@ -10,6 +10,7 @@
#include "base/files/file_util.h"
#include "base/memory/scoped_ptr.h"
#include "base/test/scoped_path_override.h"
+#include "chromecast/base/scoped_temp_file.h"
#include "chromecast/crash/linux/crash_testing_utils.h"
#include "chromecast/crash/linux/dump_info.h"
#include "chromecast/crash/linux/minidump_generator.h"
@@ -46,10 +47,11 @@ class MinidumpWriterTest : public testing::Test {
void SetUp() override {
// Set up a temporary directory which will be used as our fake home dir.
- base::FilePath fake_home_dir;
- ASSERT_TRUE(base::CreateNewTempDirectory("", &fake_home_dir));
- home_.reset(new base::ScopedPathOverride(base::DIR_HOME, fake_home_dir));
- minidump_dir_ = fake_home_dir.Append(kMinidumpSubdir);
+ ASSERT_TRUE(fake_home_dir_.CreateUniqueTempDir());
+ home_.reset(
+ new base::ScopedPathOverride(base::DIR_HOME, fake_home_dir_.path()));
+
+ minidump_dir_ = fake_home_dir_.path().Append(kMinidumpSubdir);
dumplog_file_ = minidump_dir_.Append(kDumplogFile);
lockfile_path_ = minidump_dir_.Append(kLockfileName);
metadata_path_ = minidump_dir_.Append(kMetadataName);
@@ -72,6 +74,7 @@ class MinidumpWriterTest : public testing::Test {
base::FilePath metadata_path_;
private:
+ base::ScopedTempDir fake_home_dir_;
scoped_ptr<base::ScopedPathOverride> home_;
DISALLOW_COPY_AND_ASSIGN(MinidumpWriterTest);

Powered by Google App Engine
This is Rietveld 408576698