Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chromecast/base/BUILD.gn

Issue 1484713003: [Chromecast] Use ScopedTemp[File|Dir] in tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Style Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/base/BUILD.gn
diff --git a/chromecast/base/BUILD.gn b/chromecast/base/BUILD.gn
index 7ec6e603c62312c28a84c55785d89f2ee9ed1829..e34b903a604539f05cfdbb2b442d85dd45d76bc6 100644
--- a/chromecast/base/BUILD.gn
+++ b/chromecast/base/BUILD.gn
@@ -6,6 +6,7 @@ import("//chrome/version.gni") # TODO layering violation!
import("//chromecast/chromecast.gni")
import("//testing/test.gni")
+# GYP target: chromecast.gyp:cast_base
source_set("base") {
sources = [
"android/dumpstate_writer.cc",
@@ -47,6 +48,20 @@ source_set("base") {
]
}
+# GYP target: n/a
+source_set("test_support") {
+ sources = [
+ "scoped_temp_file.cc",
+ "scoped_temp_file.h",
+ ]
+
+ public_deps = [
+ ":base",
+ "//base",
+ ]
+}
+
+# GYP target: chromecast_tests.gypi:cast_base_unittests
test("cast_base_unittests") {
sources = [
"device_capabilities_impl_unittest.cc",
@@ -58,8 +73,7 @@ test("cast_base_unittests") {
]
deps = [
- ":base",
- "//base",
+ ":test_support",
"//base/test:run_all_unittests",
"//base/test:test_support",
"//testing/gmock",

Powered by Google App Engine
This is Rietveld 408576698