[Chromecast] Use ScopedTemp[File|Dir] in tests.

chromecast/crash/linux/synchronized_minidump_manager_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <fcntl.h>
 #include <stdlib.h>
 #include <sys/file.h>
 #include <sys/stat.h>   // mkdir
 #include <sys/types.h>  //
 #include <stdio.h>      // perror
 #include <time.h>
 
 #include <fstream>
 
 #include "base/base_paths.h"
 #include "base/bind.h"
 #include "base/files/file.h"
 #include "base/files/file_util.h"
+#include "base/files/scoped_temp_dir.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/process/launch.h"
 #include "base/test/scoped_path_override.h"
 #include "base/threading/platform_thread.h"
 #include "base/threading/thread.h"
+#include "chromecast/base/scoped_temp_file.h"
 #include "chromecast/crash/linux/crash_testing_utils.h"
 #include "chromecast/crash/linux/dump_info.h"
 #include "chromecast/crash/linux/synchronized_minidump_manager.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromecast {
 namespace {
 
 const char kLockfileName[] = "lockfile";
 const char kMetadataName[] = "metadata";
@@ skipping 95 matching lines @@
   const int sleep_duration_ms_;
 };
 
 class SynchronizedMinidumpManagerTest : public testing::Test {
  public:
   SynchronizedMinidumpManagerTest() {}
   ~SynchronizedMinidumpManagerTest() override {}
 
   void SetUp() override {
     // Set up a temporary directory which will be used as our fake home dir.
-    ASSERT_TRUE(base::CreateNewTempDirectory("", &fake_home_dir_));
+    ASSERT_TRUE(fake_home_dir_.CreateUniqueTempDir());
     path_override_.reset(
-        new base::ScopedPathOverride(base::DIR_HOME, fake_home_dir_));
-    minidump_dir_ = fake_home_dir_.Append(kMinidumpSubdir);
+        new base::ScopedPathOverride(base::DIR_HOME, fake_home_dir_.path()));
+
+    minidump_dir_ = fake_home_dir_.path().Append(kMinidumpSubdir);
     lockfile_ = minidump_dir_.Append(kLockfileName);
     metadata_ = minidump_dir_.Append(kMetadataName);
 
     // Create a minidump directory.
     ASSERT_TRUE(base::CreateDirectory(minidump_dir_));
     ASSERT_TRUE(base::IsDirectoryEmpty(minidump_dir_));
 
     // Create a lockfile in that directory.
     base::File lockfile(
         lockfile_, base::File::FLAG_CREATE_ALWAYS | base::File::FLAG_WRITE);
     ASSERT_TRUE(lockfile.IsValid());
   }
 
-  void TearDown() override {
-    // Remove the temp directory.
-    path_override_.reset();
-    ASSERT_TRUE(base::DeleteFile(fake_home_dir_, true));
-  }
-
  protected:
-  base::FilePath fake_home_dir_;  // Path to the test home directory.
   base::FilePath minidump_dir_;   // Path the the minidump directory.
   base::FilePath lockfile_;       // Path to the lockfile in |minidump_dir_|.
   base::FilePath metadata_;       // Path to the metadata in |minidump_dir_|.
 
  private:
+  base::ScopedTempDir fake_home_dir_;
   scoped_ptr<base::ScopedPathOverride> path_override_;
 };
 
 // Have |producer| generate |num_dumps| while checking there are no errors.
 void produce_dumps(SynchronizedMinidumpManagerSimple& producer, int num_dumps) {
   for (int i = 0; i < num_dumps; ++i) {
     ASSERT_EQ(0, producer.DoWorkLocked());
     ASSERT_EQ(0, producer.add_entry_return_code());
   }
 }
@@ skipping 366 matching lines @@
   const base::FilePath path =
       base::FilePath(manager.dump_path()).Append("hello123");
   const char kFileContents[] = "foobar";
   ASSERT_EQ(static_cast<int>(sizeof(kFileContents)),
             WriteFile(path, kFileContents, sizeof(kFileContents)));
 
   ASSERT_TRUE(manager.HasDumps());
 }
 
 }  // namespace chromecast