[Chromecast] Use ScopedTemp[File|Dir] in tests.

chromecast/crash/cast_crashdump_uploader_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/files/file_util.h"
 #include "breakpad/src/common/linux/libcurl_wrapper.h"
+#include "chromecast/base/scoped_temp_file.h"
 #include "chromecast/crash/cast_crashdump_uploader.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromecast {
 
 class MockLibcurlWrapper : public google_breakpad::LibcurlWrapper {
  public:
   MOCK_METHOD0(Init, bool());
   MOCK_METHOD2(SetProxy,
@@ skipping 28 matching lines @@
   data.crash_server = "http://foo.com";
   CastCrashdumpUploader uploader(data, &m);
 
   ASSERT_FALSE(uploader.Upload(nullptr));
 }
 
 TEST(CastCrashdumpUploaderTest, UploadSucceedsWithValidParameters) {
   testing::StrictMock<MockLibcurlWrapper> m;
 
   // Create a temporary file.
-  base::FilePath temp;
-  ASSERT_TRUE(base::CreateTemporaryFile(&temp));
+  ScopedTempFile minidump;
 
   EXPECT_CALL(m, Init()).Times(1).WillOnce(Return(true));
-  EXPECT_CALL(m, AddFile(temp.value(), _)).WillOnce(Return(true));
+  EXPECT_CALL(m, AddFile(minidump.path().value(), _)).WillOnce(Return(true));
   EXPECT_CALL(m, SendRequest("http://foo.com", _, _, _, _)).Times(1).WillOnce(
       Return(true));
 
   CastCrashdumpData data;
   data.product = "foobar";
   data.version = "1.0";
   data.guid = "AAA-BBB";
   data.email = "test@test.com";
   data.comments = "none";
-  data.minidump_pathname = temp.value();
+  data.minidump_pathname = minidump.path().value();
   data.crash_server = "http://foo.com";
   CastCrashdumpUploader uploader(data, &m);
 
   ASSERT_TRUE(uploader.Upload(nullptr));
 }
 
 TEST(CastCrashdumpUploaderTest, UploadFailsWithInvalidPathname) {
   testing::StrictMock<MockLibcurlWrapper> m;
   EXPECT_CALL(m, Init()).Times(1).WillOnce(Return(true));
   EXPECT_CALL(m, SendRequest(_, _, _, _, _)).Times(0);
 
   CastCrashdumpData data;
   data.product = "foobar";
   data.version = "1.0";
   data.guid = "AAA-BBB";
   data.email = "test@test.com";
   data.comments = "none";
   data.minidump_pathname = "/invalid/file/path";
   data.crash_server = "http://foo.com";
   CastCrashdumpUploader uploader(data, &m);
 
   ASSERT_FALSE(uploader.Upload(nullptr));
 }
 
 TEST(CastCrashdumpUploaderTest, UploadFailsWithoutAllRequiredParameters) {
   testing::StrictMock<MockLibcurlWrapper> m;
 
   // Create a temporary file.
-  base::FilePath temp;
-  ASSERT_TRUE(base::CreateTemporaryFile(&temp));
+  ScopedTempFile minidump;
 
   // Has all the require fields for a crashdump.
   CastCrashdumpData data;
   data.product = "foobar";
   data.version = "1.0";
   data.guid = "AAA-BBB";
   data.email = "test@test.com";
   data.comments = "none";
-  data.minidump_pathname = temp.value();
+  data.minidump_pathname = minidump.path().value();
   data.crash_server = "http://foo.com";
 
   // Test with empty product name.
   data.product = "";
   EXPECT_CALL(m, Init()).Times(1).WillOnce(Return(true));
   CastCrashdumpUploader uploader_no_product(data, &m);
   ASSERT_FALSE(uploader_no_product.Upload(nullptr));
   data.product = "foobar";
 
   // Test with empty product version.
   data.version = "";
   EXPECT_CALL(m, Init()).Times(1).WillOnce(Return(true));
   CastCrashdumpUploader uploader_no_version(data, &m);
   ASSERT_FALSE(uploader_no_version.Upload(nullptr));
   data.version = "1.0";
 
   // Test with empty client GUID.
   data.guid = "";
   EXPECT_CALL(m, Init()).Times(1).WillOnce(Return(true));
   CastCrashdumpUploader uploader_no_guid(data, &m);
   ASSERT_FALSE(uploader_no_guid.Upload(nullptr));
 }
 
 TEST(CastCrashdumpUploaderTest, UploadFailsWithInvalidAttachment) {
   testing::StrictMock<MockLibcurlWrapper> m;
 
   // Create a temporary file.
-  base::FilePath minidump;
-  ASSERT_TRUE(base::CreateTemporaryFile(&minidump));
+  ScopedTempFile minidump;
 
   EXPECT_CALL(m, Init()).Times(1).WillOnce(Return(true));
-  EXPECT_CALL(m, AddFile(minidump.value(), _)).WillOnce(Return(true));
+  EXPECT_CALL(m, AddFile(minidump.path().value(), _)).WillOnce(Return(true));
 
   CastCrashdumpData data;
   data.product = "foobar";
   data.version = "1.0";
   data.guid = "AAA-BBB";
   data.email = "test@test.com";
   data.comments = "none";
-  data.minidump_pathname = minidump.value();
+  data.minidump_pathname = minidump.path().value();
   data.crash_server = "http://foo.com";
   CastCrashdumpUploader uploader(data, &m);
 
   // Add a file that does not exist as an attachment.
   uploader.AddAttachment("label", "/path/does/not/exist");
   ASSERT_FALSE(uploader.Upload(nullptr));
 }
 
 TEST(CastCrashdumpUploaderTest, UploadSucceedsWithValidAttachment) {
   testing::StrictMock<MockLibcurlWrapper> m;
 
   // Create a temporary file.
-  base::FilePath minidump;
-  ASSERT_TRUE(base::CreateTemporaryFile(&minidump));
+  ScopedTempFile minidump;
 
   // Create a valid attachment.
-  base::FilePath attachment;
-  ASSERT_TRUE(base::CreateTemporaryFile(&attachment));
+  ScopedTempFile attachment;
 
   EXPECT_CALL(m, Init()).Times(1).WillOnce(Return(true));
-  EXPECT_CALL(m, AddFile(minidump.value(), _)).WillOnce(Return(true));
-  EXPECT_CALL(m, AddFile(attachment.value(), _)).WillOnce(Return(true));
+  EXPECT_CALL(m, AddFile(minidump.path().value(), _)).WillOnce(Return(true));
+  EXPECT_CALL(m, AddFile(attachment.path().value(), _)).WillOnce(Return(true));
   EXPECT_CALL(m, SendRequest(_, _, _, _, _)).Times(1).WillOnce(Return(true));
 
   CastCrashdumpData data;
   data.product = "foobar";
   data.version = "1.0";
   data.guid = "AAA-BBB";
   data.email = "test@test.com";
   data.comments = "none";
-  data.minidump_pathname = minidump.value();
+  data.minidump_pathname = minidump.path().value();
   data.crash_server = "http://foo.com";
   CastCrashdumpUploader uploader(data, &m);
 
-  // Add a file that does not exist as an attachment.
-  uploader.AddAttachment("label", attachment.value());
+  // Add a valid file as an attachment.
+  uploader.AddAttachment("label", attachment.path().value());
   ASSERT_TRUE(uploader.Upload(nullptr));
 }
 
 }  // namespace chromeceast